Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(controller): Increase readiness timeout from 1s to 30s #6007

Merged
merged 2 commits into from May 25, 2021

Conversation

alexec
Copy link
Contributor

@alexec alexec commented May 25, 2021

1s is too short under stress. I want to be cautious about restarting, hence 30s rather than a shorter time like 10s.

Signed-off-by: Alex Collins <alex_collins@intuit.com>
Signed-off-by: Alex Collins <alex_collins@intuit.com>
@alexec alexec marked this pull request as ready for review May 25, 2021 17:14
@alexec alexec added this to the v3.0 milestone May 25, 2021
@alexec alexec enabled auto-merge (squash) May 25, 2021 17:14
@codecov
Copy link

codecov bot commented May 25, 2021

Codecov Report

Merging #6007 (b7fa185) into master (d7517cf) will increase coverage by 0.01%.
The diff coverage is n/a.

❗ Current head b7fa185 differs from pull request most recent head d903f13. Consider uploading reports for the commit d903f13 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6007      +/-   ##
==========================================
+ Coverage   47.33%   47.35%   +0.01%     
==========================================
  Files         248      248              
  Lines       15655    15655              
==========================================
+ Hits         7411     7413       +2     
+ Misses       7313     7312       -1     
+ Partials      931      930       -1     
Impacted Files Coverage Δ
cmd/argo/commands/get.go 57.09% <0.00%> (+0.64%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d7517cf...d903f13. Read the comment docs.

@alexec alexec merged commit 7e27044 into argoproj:master May 25, 2021
@alexec alexec deleted the timeout branch May 25, 2021 18:26
alexec added a commit that referenced this pull request May 25, 2021
Signed-off-by: Alex Collins <alex_collins@intuit.com>
@sarabala1979 sarabala1979 mentioned this pull request Jun 10, 2021
88 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants