Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: Multi-cluster workflows. Fixes #6089, #3523, #2063 #6587

Closed
wants to merge 35 commits into from
Closed

Conversation

alexec
Copy link
Contributor

@alexec alexec commented Aug 23, 2021

Signed-off-by: Alex Collins alex_collins@intuit.com
Fixes #6089
Fixes #3523
Fixes #2063



Signed-off-by: Alex Collins <alex_collins@intuit.com>
@codecov
Copy link

codecov bot commented Aug 23, 2021

Codecov Report

Merging #6587 (66c1450) into master (6d46fd9) will decrease coverage by 0.27%.
The diff coverage is 34.95%.

❗ Current head 66c1450 differs from pull request most recent head 9eb6b70. Consider uploading reports for the commit 9eb6b70 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6587      +/-   ##
==========================================
- Coverage   48.55%   48.28%   -0.28%     
==========================================
  Files         262      263       +1     
  Lines       18991    19177     +186     
==========================================
+ Hits         9222     9260      +38     
- Misses       8741     8884     +143     
- Partials     1028     1033       +5     
Impacted Files Coverage Δ
config/config.go 31.57% <ø> (ø)
pkg/apis/workflow/v1alpha1/workflow_types.go 49.55% <0.00%> (-0.79%) ⬇️
workflow/common/common.go 80.00% <ø> (ø)
workflow/controller/finalizer.go 0.00% <0.00%> (ø)
workflow/controller/controller.go 20.92% <27.08%> (-1.28%) ⬇️
workflow/controller/pod_cleanup_key.go 28.57% <33.33%> (ø)
workflow/controller/workflowpod.go 72.22% <45.61%> (-2.35%) ⬇️
workflow/controller/indexes/workflow_index.go 33.33% <50.00%> (ø)
workflow/controller/node_counters.go 94.73% <71.42%> (-5.27%) ⬇️
workflow/controller/exec_control.go 62.74% <75.00%> (+3.17%) ⬆️
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6d46fd9...9eb6b70. Read the comment docs.

Signed-off-by: Alex Collins <alex_collins@intuit.com>
Signed-off-by: Alex Collins <alex_collins@intuit.com>
@alexec alexec closed this Aug 24, 2021
Signed-off-by: Alex Collins <alex_collins@intuit.com>
Signed-off-by: Alex Collins <alex_collins@intuit.com>
Signed-off-by: Alex Collins <alex_collins@intuit.com>
@alexec alexec reopened this Aug 24, 2021
Signed-off-by: Alex Collins <alex_collins@intuit.com>
Signed-off-by: Alex Collins <alex_collins@intuit.com>
Signed-off-by: Alex Collins <alex_collins@intuit.com>
Signed-off-by: Alex Collins <alex_collins@intuit.com>
Signed-off-by: Alex Collins <alex_collins@intuit.com>
Signed-off-by: Alex Collins <alex_collins@intuit.com>
Signed-off-by: Alex Collins <alex_collins@intuit.com>
@alexec alexec changed the title feat: Multi-cloud/cluster/namespace workflows. Fixes #6089, #3523, #2063 feat: Multi-cluster workflows. Fixes #6089, #3523, #2063 Aug 25, 2021
Signed-off-by: Alex Collins <alex_collins@intuit.com>
Signed-off-by: Alex Collins <alex_collins@intuit.com>
Signed-off-by: Alex Collins <alex_collins@intuit.com>
o
Signed-off-by: Alex Collins <alex_collins@intuit.com>
Signed-off-by: Alex Collins <alex_collins@intuit.com>
Signed-off-by: Alex Collins <alex_collins@intuit.com>
Signed-off-by: Alex Collins <alex_collins@intuit.com>
Signed-off-by: Alex Collins <alex_collins@intuit.com>
Signed-off-by: Alex Collins <alex_collins@intuit.com>
Signed-off-by: Alex Collins <alex_collins@intuit.com>
Signed-off-by: Alex Collins <alex_collins@intuit.com>
Signed-off-by: Alex Collins <alex_collins@intuit.com>
Signed-off-by: Alex Collins <alex_collins@intuit.com>
Signed-off-by: Alex Collins <alex_collins@intuit.com>
@alexec alexec changed the title feat: Multi-cluster workflows. Fixes #6089, #3523, #2063 feat!: Multi-cluster workflows. Fixes #6089, #3523, #2063 Aug 28, 2021
Signed-off-by: Alex Collins <alex_collins@intuit.com>
Signed-off-by: Alex Collins <alex_collins@intuit.com>
Signed-off-by: Alex Collins <alex_collins@intuit.com>
Signed-off-by: Alex Collins <alex_collins@intuit.com>
Signed-off-by: Alex Collins <alex_collins@intuit.com>
Signed-off-by: Alex Collins <alex_collins@intuit.com>
Signed-off-by: Alex Collins <alex_collins@intuit.com>
Signed-off-by: Alex Collins <alex_collins@intuit.com>
@alexec alexec linked an issue Sep 20, 2021 that may be closed by this pull request
@alexec alexec closed this Sep 30, 2021
@alexec alexec deleted the dev-mc branch September 30, 2021 21:14
@tarungulati1988
Copy link

tarungulati1988 commented Oct 15, 2021

@alexec Do the docs have an example for a multi name space workflow or a multi cluster workflow that you could point me to?

@agilgur5
Copy link
Member

Replaced by #6804 and #8120, neither of which reached the finish line either unfortunately 😕

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants