feat(server): archivedWf add namePrefix search. Fixes #6743

[tczhao]

Fixes #6743

Tips:

• Maybe add you organization to USERS.md.
• Your PR needs to pass the required checks before it can be approved. If the check is not required (e.g. E2E tests) it does not need to pass
• Sign-off your commits to pass the DCO check: git commit --signoff.
• Run make pre-commit -B to fix codegen or lint problems.
• Say how how you tested your changes. If you changed the UI, attach screenshots.
• If changes were requested, and you've made them, then dismis the review to get it looked at again.
• You can ask for help!

[codecov]

Codecov Report

Merging #6801 (5ced741) into master (689ad68) will increase coverage by 0.01%.
The diff coverage is 25.00%.

@@            Coverage Diff             @@
##           master    #6801      +/-   ##
==========================================
+ Coverage   48.55%   48.56%   +0.01%     
==========================================
  Files         265      265              
  Lines       19220    19228       +8     
==========================================
+ Hits         9332     9338       +6     
+ Misses       8839     8837       -2     
- Partials     1049     1053       +4     

Impacted Files	Coverage Δ
persist/sqldb/migrate.go	0.00% <0.00%> (ø)
persist/sqldb/null_workflow_archive.go	0.00% <0.00%> (ø)
persist/sqldb/workflow_archive.go	0.00% <0.00%> (ø)
server/workflowarchive/archived_workflow_server.go	59.43% <100.00%> (+0.38%)	⬆️
...orkflow/controller/estimation/estimator_factory.go	70.00% <100.00%> (ø)
cmd/argoexec/commands/emissary.go	50.35% <0.00%> (-1.44%)	⬇️
workflow/controller/operator.go	71.11% <0.00%> (-0.10%)	⬇️
server/workflow/workflow_server.go	46.80% <0.00%> (+2.39%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 689ad68...5ced741. Read the comment docs.

[alexec]

The use case here appears to be that the leading part of the name should match an expression.

To achieve this, you need name like 'prefix-%' condition.

I think this should be a separate query parameter name prefix and this is only used with like ${prefix}%. You'll need a new func named hasPrefix similar to nameEquals.

Do we have an index on name? Can you please check?

[tczhao]

we don't have index on name
current indexes

    "argo_archived_workflows_pkey" PRIMARY KEY, btree (clustername, uid)
    "argo_archived_workflows_i1" btree (clustername, instanceid, namespace)
    "argo_archived_workflows_i2" btree (clustername, instanceid, finishedat)

would you recommend to
add (clustername, instanceid, name) index,
default the search bar behaviour to find through prefix matching,
and remove the exact match

[alexec]

would you recommend to add (clustername, instanceid, name) index,

yes. what about the labels table?

[tczhao]

Hi @alexec , any further comments?

[alexec]

I've reviewed the code and this is a breaking change, but we can modify it to remove the breaking change.

We should continue to support name=, via list.Option.fieldSelector=metadata.name and add namePrefix as another option to.

message ListArchivedWorkflowsRequest {
    k8s.io.apimachinery.pkg.apis.meta.v1.ListOptions listOptions = 1;
    string namePrefix = 2;
}

That means where we had name we now want name and namePrefix. If both are supplied, which would be odd, both must pass.

[tczhao]

updated

[alexec]

Awesome. Looks a lot neater like this. Great work!