Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Fix docs build. Fixes #7023 #7024

Merged
merged 3 commits into from
Oct 21, 2021
Merged

docs: Fix docs build. Fixes #7023 #7024

merged 3 commits into from
Oct 21, 2021

Conversation

alexec
Copy link
Contributor

@alexec alexec commented Oct 21, 2021

Signed-off-by: Alex Collins alex_collins@intuit.com
Fixes #7023

Signed-off-by: Alex Collins <alex_collins@intuit.com>
@alexec alexec changed the title docs: Fix docs build docs: Fix docs build. Fixes #7023 Oct 21, 2021
@codecov
Copy link

codecov bot commented Oct 21, 2021

Codecov Report

Merging #7024 (008b979) into master (7414573) will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #7024      +/-   ##
==========================================
+ Coverage   48.54%   48.55%   +0.01%     
==========================================
  Files         265      265              
  Lines       19281    19281              
==========================================
+ Hits         9359     9361       +2     
  Misses       8868     8868              
+ Partials     1054     1052       -2     
Impacted Files Coverage Δ
workflow/metrics/server.go 15.78% <0.00%> (-3.51%) ⬇️
cmd/argo/commands/get.go 59.76% <0.00%> (+0.58%) ⬆️
cmd/argoexec/commands/emissary.go 51.79% <0.00%> (+1.43%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7414573...008b979. Read the comment docs.

Signed-off-by: Alex Collins <alex_collins@intuit.com>
@alexec alexec marked this pull request as ready for review October 21, 2021 22:08
python-version: 3.x
- name: Setup Golang
uses: actions/setup-go@v1
python-version: 3.9
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is the actual fix

@alexec alexec enabled auto-merge (squash) October 21, 2021 22:09
Copy link
Member

@terrytangyuan terrytangyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@alexec alexec disabled auto-merge October 21, 2021 23:40
@alexec alexec merged commit 93c301d into master Oct 21, 2021
@alexec alexec deleted the dev-pages branch October 21, 2021 23:40
SunSparc pushed a commit to SunSparc/argo-workflows that referenced this pull request Oct 22, 2021
Signed-off-by: Jonathan Duncan <jonathan@nacnud.com>
kriti-sc pushed a commit to kriti-sc/argo-workflows that referenced this pull request Oct 24, 2021
Signed-off-by: kriti-sc <kathuriakriti1@gmail.com>
alexec added a commit that referenced this pull request Oct 24, 2021
Signed-off-by: Alex Collins <alex_collins@intuit.com>
@sarabala1979 sarabala1979 mentioned this pull request Oct 26, 2021
25 tasks
@sarabala1979 sarabala1979 mentioned this pull request Nov 4, 2021
25 tasks
@sarabala1979 sarabala1979 mentioned this pull request Mar 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Docs no longer building on master
2 participants