-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support new field - RFC3339 in creationTimeStamp. Fixes #6906 #7044
Conversation
Signed-off-by: ziv-codefresh <ziv@codefresh.io>
Signed-off-by: ziv-codefresh <ziv@codefresh.io>
8f0f8ab
to
fe99ce1
Compare
Co-authored-by: Simon Behar <simbeh7@gmail.com> Signed-off-by: ziv-codefresh <ziv@codefresh.io>
0ce6e11
to
8537aca
Compare
@simster7 sounds good, ive update the documentation. |
Codecov Report
@@ Coverage Diff @@
## master #7044 +/- ##
==========================================
- Coverage 48.56% 48.56% -0.01%
==========================================
Files 265 265
Lines 19294 19295 +1
==========================================
- Hits 9371 9370 -1
- Misses 8870 8872 +2
Partials 1053 1053
Continue to review full report at Codecov.
|
@simster7 all the checks passed, if everything looks good from your hand i think we can merge it. thank you! |
…roj#7044) Signed-off-by: kriti-sc <kathuriakriti1@gmail.com>
support RFC3339 new property in creationTimeStamp.
the issue was raised here - #6906
ive added additional property in creationTimeStamp that will represent this format, as @alexec suggested.
example of usage is:
the output will be in RFC3339 format as expected.