Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support new field - RFC3339 in creationTimeStamp. Fixes #6906 #7044

Merged
merged 3 commits into from
Oct 23, 2021

Conversation

ziv-codefresh
Copy link
Contributor

@ziv-codefresh ziv-codefresh commented Oct 23, 2021

support RFC3339 new property in creationTimeStamp.

the issue was raised here - #6906
ive added additional property in creationTimeStamp that will represent this format, as @alexec suggested.

example of usage is:

apiVersion: argoproj.io/v1alpha1
kind: Workflow
metadata:
  generateName: steps-
spec:
  entrypoint: hello

  templates:
  - name: hello
    steps:
    - - name: h1
        template: whalesay
        arguments:
          parameters:
          - name: message
            value: "{{= workflow.creationTimestamp.RFC3339 }}"

  - name: whalesay
    inputs:
      parameters:
      - name: message
    container:
      image: docker/whalesay
      command: [cowsay]
      args: ["{{inputs.parameters.message}}"]

the output will be in RFC3339 format as expected.

  • modified the unit test to check this property aswell.

Signed-off-by: ziv-codefresh <ziv@codefresh.io>
Signed-off-by: ziv-codefresh <ziv@codefresh.io>
@ziv-codefresh ziv-codefresh changed the title support RFC3339 in creationTimeStamp field fix:RFC3339 in creationTimeStamp field Oct 23, 2021
@ziv-codefresh ziv-codefresh changed the title fix:RFC3339 in creationTimeStamp field fix: RFC3339 in creationTimeStamp field Oct 23, 2021
@ziv-codefresh ziv-codefresh changed the title fix: RFC3339 in creationTimeStamp field fix: support new field - RFC3339 in creationTimeStamp Oct 23, 2021
@ziv-codefresh ziv-codefresh changed the title fix: support new field - RFC3339 in creationTimeStamp feat: support new field - RFC3339 in creationTimeStamp Oct 23, 2021
@ziv-codefresh ziv-codefresh changed the title feat: support new field - RFC3339 in creationTimeStamp feat: support new field - RFC3339 in creationTimeStamp. Fixes #6906 Oct 23, 2021
docs/variables.md Outdated Show resolved Hide resolved
@simster7 simster7 self-assigned this Oct 23, 2021
Co-authored-by: Simon Behar <simbeh7@gmail.com>
Signed-off-by: ziv-codefresh <ziv@codefresh.io>
@ziv-codefresh
Copy link
Contributor Author

@simster7 sounds good, ive update the documentation.

@codecov
Copy link

codecov bot commented Oct 23, 2021

Codecov Report

Merging #7044 (8537aca) into master (0758eab) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #7044      +/-   ##
==========================================
- Coverage   48.56%   48.56%   -0.01%     
==========================================
  Files         265      265              
  Lines       19294    19295       +1     
==========================================
- Hits         9371     9370       -1     
- Misses       8870     8872       +2     
  Partials     1053     1053              
Impacted Files Coverage Δ
workflow/controller/operator.go 71.29% <100.00%> (+0.15%) ⬆️
cmd/argoexec/commands/emissary.go 50.35% <0.00%> (-1.44%) ⬇️
cmd/argo/commands/get.go 58.89% <0.00%> (-0.88%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0758eab...8537aca. Read the comment docs.

@ziv-codefresh
Copy link
Contributor Author

@simster7 all the checks passed, if everything looks good from your hand i think we can merge it. thank you!

@simster7 simster7 merged commit 0baa4a2 into argoproj:master Oct 23, 2021
kriti-sc pushed a commit to kriti-sc/argo-workflows that referenced this pull request Oct 24, 2021
…roj#7044)

Signed-off-by: kriti-sc <kathuriakriti1@gmail.com>
@sarabala1979 sarabala1979 mentioned this pull request Oct 26, 2021
25 tasks
@sarabala1979 sarabala1979 mentioned this pull request Nov 4, 2021
25 tasks
alexec pushed a commit that referenced this pull request Nov 17, 2021
Signed-off-by: Alex Collins <alex_collins@intuit.com>
@sarabala1979 sarabala1979 mentioned this pull request Dec 15, 2021
73 tasks
@sarabala1979 sarabala1979 mentioned this pull request Mar 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants