Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Ensure HTTP templates have children assigned #7082

Merged
merged 1 commit into from
Oct 27, 2021

Conversation

simster7
Copy link
Member

@simster7 simster7 commented Oct 27, 2021

Fixes: #7079, #7072

Signed-off-by: Simon Behar simbeh7@gmail.com

Tips:

  • Maybe add you organization to USERS.md.
  • Your PR needs to pass the required checks before it can be approved. If the check is not required (e.g. E2E tests) it does not need to pass
  • Sign-off your commits to pass the DCO check: git commit --signoff.
  • Run make pre-commit -B to fix codegen or lint problems.
  • Say how how you tested your changes. If you changed the UI, attach screenshots.
  • If changes were requested, and you've made them, then dismiss the review to get it looked at again.
  • You can ask for help!

Signed-off-by: Simon Behar <simbeh7@gmail.com>
@@ -3320,3 +3320,85 @@ func TestDAGReferTaskAggregatedOutputs(t *testing.T) {
}
}
}

var dagHttpChildrenAssigned = `apiVersion: argoproj.io/v1alpha1
Copy link
Member Author

@simster7 simster7 Oct 27, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Already ensured this is minimal

@codecov
Copy link

codecov bot commented Oct 27, 2021

Codecov Report

Merging #7082 (8fb49c1) into master (832ae29) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

❗ Current head 8fb49c1 differs from pull request most recent head c723eb5. Consider uploading reports for the commit c723eb5 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master    #7082      +/-   ##
==========================================
- Coverage   48.57%   48.56%   -0.02%     
==========================================
  Files         265      265              
  Lines       19315    19315              
==========================================
- Hits         9383     9381       -2     
- Misses       8878     8880       +2     
  Partials     1054     1054              
Impacted Files Coverage Δ
workflow/controller/operator.go 71.29% <100.00%> (+0.14%) ⬆️
cmd/argoexec/commands/emissary.go 50.35% <0.00%> (-1.44%) ⬇️
cmd/argo/commands/get.go 58.89% <0.00%> (-0.88%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 832ae29...c723eb5. Read the comment docs.

@simster7
Copy link
Member Author

Test failures are transient/time-outs: unrelated

@sarabala1979 sarabala1979 enabled auto-merge (squash) October 27, 2021 16:16
@simster7 simster7 enabled auto-merge (squash) October 27, 2021 16:47
@simster7 simster7 merged commit d6a62c3 into argoproj:master Oct 27, 2021
@alexec alexec mentioned this pull request Nov 5, 2021
25 tasks
alexec pushed a commit that referenced this pull request Nov 17, 2021
Signed-off-by: Simon Behar <simbeh7@gmail.com>
@sarabala1979 sarabala1979 mentioned this pull request Dec 15, 2021
73 tasks
@sarabala1979 sarabala1979 mentioned this pull request Mar 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

multiple http steps in DAG run indefinitely
2 participants