-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Ensure HTTP templates have children assigned #7082
Conversation
Signed-off-by: Simon Behar <simbeh7@gmail.com>
@@ -3320,3 +3320,85 @@ func TestDAGReferTaskAggregatedOutputs(t *testing.T) { | |||
} | |||
} | |||
} | |||
|
|||
var dagHttpChildrenAssigned = `apiVersion: argoproj.io/v1alpha1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Already ensured this is minimal
Codecov Report
@@ Coverage Diff @@
## master #7082 +/- ##
==========================================
- Coverage 48.57% 48.56% -0.02%
==========================================
Files 265 265
Lines 19315 19315
==========================================
- Hits 9383 9381 -2
- Misses 8878 8880 +2
Partials 1054 1054
Continue to review full report at Codecov.
|
Test failures are transient/time-outs: unrelated |
Signed-off-by: Simon Behar <simbeh7@gmail.com>
Fixes: #7079, #7072
Signed-off-by: Simon Behar simbeh7@gmail.com
Tips:
git commit --signoff
.make pre-commit -B
to fix codegen or lint problems.