fix: Ensure HTTP reconciliation occurs for onExit nodes #7084
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Simon Behar <simbeh7@gmail.com>
simster7
commented
Oct 27, 2021
| node.Outputs = taskResult.Outputs.DeepCopy() | ||
| node.Phase = taskResult.Phase | ||
| node.Message = taskResult.Message | ||
| woc.wf.Status.Nodes[nodeID] = node | ||
| node.FinishedAt = metav1.Now() |
There was a problem hiding this comment.
Previously update happened before FinishedAt was set. A separate likely source of bugs
Codecov Report
@@ Coverage Diff @@
## master #7084 +/- ##
==========================================
+ Coverage 48.57% 48.60% +0.02%
==========================================
Files 265 265
Lines 19315 19329 +14
==========================================
+ Hits 9383 9395 +12
- Misses 8878 8880 +2
Partials 1054 1054
Continue to review full report at Codecov.
|
workflow/controller/operator.go
Outdated
| @@ -477,6 +473,21 @@ func (woc *wfOperationCtx) operate(ctx context.Context) { | |||
| } | |||
| } | |||
|
|
|||
| func (woc *wfOperationCtx) httpReconciliation(ctx context.Context) { | |||
There was a problem hiding this comment.
Can you move this function to http_template.go?
sarabala1979
approved these changes
Oct 27, 2021
alexec
pushed a commit
that referenced
this pull request
Nov 17, 2021
* fix: Ensure HTTP reconciliation occurs for onExit nodes Signed-off-by: Simon Behar <simbeh7@gmail.com> * tests Signed-off-by: Simon Behar <simbeh7@gmail.com> * fixes Signed-off-by: Simon Behar <simbeh7@gmail.com> * minor Signed-off-by: Simon Behar <simbeh7@gmail.com>
Closed
3 tasks
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7080
Tips:
git commit --signoff.make pre-commit -Bto fix codegen or lint problems.