Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ui): Correctly show zero-state when CRDs not installed. Fixes #7001 #7169

Merged
merged 1 commit into from
Nov 4, 2021

Conversation

alexec
Copy link
Contributor

@alexec alexec commented Nov 4, 2021

Signed-off-by: Alex Collins alex_collins@intuit.com
Fixes #7001

Don't bother creating a PR until you've done this:

  • Run make pre-commit -B to fix codegen, lint, and commit message problems.

Create your PR as a draft.

  • Your PR needs to pass the required checks before it can be approved. If the check is not required (e.g. E2E tests) it
    does not need to pass.
  • Once required tests have passed, you can make it "Ready for review".
  • Say how how you tested your changes. If you changed the UI, attach screenshots.

Tips:

  • If changes were requested, and you've made them, then dismiss the review to get it looked at again.
  • Add you organization to USERS.md if you like.
  • You can ask for help!

Screenshot 2021-11-04 at 08 21 27
Screenshot 2021-11-04 at 08 21 39
Screenshot 2021-10-31 at 11 17 45

…oproj#7001

Signed-off-by: Alex Collins <alex_collins@intuit.com>
@alexec alexec marked this pull request as ready for review November 4, 2021 18:16
Copy link
Member

@terrytangyuan terrytangyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you paste the screenshots after this change?

@alexec
Copy link
Contributor Author

alexec commented Nov 4, 2021

Could you paste the screenshots after this change?

That is the screen shots I've attached?

@terrytangyuan
Copy link
Member

It might be better to remove the "Not Found" notice at the top since this is the default behavior and we don't assume users have those installed.

@alexec
Copy link
Contributor Author

alexec commented Nov 4, 2021

It might be better to remove the "Not Found"

I don't think you can differentiate "Not Found" from other errors.

@alexec alexec merged commit 0482964 into argoproj:master Nov 4, 2021
@alexec alexec deleted the signposts branch November 4, 2021 19:52
@alexec alexec mentioned this pull request Nov 5, 2021
25 tasks
alexec added a commit that referenced this pull request Nov 17, 2021
… (#7169)

Signed-off-by: Alex Collins <alex_collins@intuit.com>
@sarabala1979 sarabala1979 mentioned this pull request Dec 15, 2021
73 tasks
@sarabala1979 sarabala1979 mentioned this pull request Mar 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve signposting for integrations
2 participants