fix: http template doesn't update progress. Fixes #7239 #7450
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: softwarebloat <nico.lino1991@gmail.com>
Closed
|
@softwarebloat is it ready to review? |
|
@sarabala1979 yes it is. only thing is that i wasn't able to try it locally but, if the test i wrote is correct, it should work 🤞 |
Sure, have you tried |
Yes I tried |
simster7
approved these changes
Jan 4, 2022
|
@sarabala1979 were you able to test it locally? |
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To me the PR is ready but i'm not able to try it locally as stated in #7436
That's why i left it as Draft