Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: out of range in MustUnmarshal #7485

Merged
merged 1 commit into from
Jan 5, 2022
Merged

Conversation

AdamKorcz
Copy link
Contributor

@AdamKorcz AdamKorcz commented Jan 3, 2022

This adds a more readable and easier recoverable message for the case when the input is of length 0.

This was reported by OSS-fuzz (issue 43202).

Copy link
Member

@terrytangyuan terrytangyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Could you add a test case and perhaps a link to the report?

@AdamKorcz
Copy link
Contributor Author

Could you add a test case and perhaps a link to the report?

done

@AdamKorcz

This comment has been minimized.

@terrytangyuan terrytangyuan marked this pull request as ready for review January 4, 2022 14:21
@terrytangyuan terrytangyuan enabled auto-merge (squash) January 4, 2022 14:22
Copy link
Member

@terrytangyuan terrytangyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also fix the lint check

Signed-off-by: AdamKorcz <adam@adalogics.com>
@terrytangyuan terrytangyuan merged commit 318927e into argoproj:master Jan 5, 2022
@terrytangyuan
Copy link
Member

@AdamKorcz Is there a link to the new report that reflects this fix?

@AdamKorcz
Copy link
Contributor Author

Thanks. The OSS-fuzz issue should resolve automatically during the next build which will most likely be sometime within 24 hours.

@terrytangyuan
Copy link
Member

Sounds good. Thanks!

@alexec alexec mentioned this pull request Jan 27, 2022
4 tasks
alexec pushed a commit that referenced this pull request Jan 27, 2022
Signed-off-by: AdamKorcz <adam@adalogics.com>
@sarabala1979 sarabala1979 mentioned this pull request Mar 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants