Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add priority field to submitopts fixes #1427 #7572

Merged
merged 1 commit into from
Jan 17, 2022

Conversation

isubasinghe
Copy link
Member

Signed-off-by: Isitha Subasinghe isitha@pipekit.io

This adds a Priority field into SubmitOpts, previously this was not present and resulted in submits with priority being broken. See #1427 for more information.

Signed-off-by: Isitha Subasinghe <isitha@pipekit.io>
@isubasinghe isubasinghe marked this pull request as ready for review January 17, 2022 13:30
Copy link
Member

@sarabala1979 sarabala1979 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sarabala1979 sarabala1979 enabled auto-merge (squash) January 17, 2022 18:22
@sarabala1979 sarabala1979 changed the title fix: add priority field to submitopts fixes #1427 feat: add priority field to submitopts fixes #1427 Jan 17, 2022
@sarabala1979 sarabala1979 merged commit dbb1bcf into argoproj:master Jan 17, 2022
yriveiro pushed a commit to yriveiro/argo-workflows that referenced this pull request Jan 27, 2022
Signed-off-by: Isitha Subasinghe <isitha@pipekit.io>
@alexec alexec mentioned this pull request Jan 27, 2022
4 tasks
@sarabala1979 sarabala1979 mentioned this pull request Mar 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants