#75: Filter dropdown at Timeline page #76
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ged the prop name to 'revision'
…d of reassigned upon tab-change
alexmt
requested changes
Aug 29, 2017
There was a problem hiding this comment.
@felixApplatix , I see following bug.
-
Navigate to Timeline commits (https://dev.applatix.net/app/timeline;view=commit;days=1;date=1503989999;failed=true;delayed=true;succeeded=true;running=true;showMyOnly=false)
-
Click jobs tab and check filter dropdown
Actual result: dropdown contains 'My commits' item
|
@alexmt I can't reproduce described issue. I remember we had that bug some time ago but it was fixed. For me filters works correct. |
wokeGit
reviewed
Aug 29, 2017
| @@ -195,10 +195,14 @@ export class TimelineComponent implements HasLayoutSettings, LayoutSettings, OnI | |||
|
|
|||
| private getFiltersByView(view) { | |||
| this.currentView = view; | |||
| let filters = []; | |||
| if (this.toolbarFilters.data) { | |||
There was a problem hiding this comment.
Is this if required?
Isn't this enough?
this.toolbarFilters.data.length = 0;
There was a problem hiding this comment.
this.toolbarFilters.data was initialized as 'undefined' at the beginning, but since it's changed to [] so I will change according to your comment.
alexmt
approved these changes
Aug 29, 2017
| @@ -195,10 +195,14 @@ export class TimelineComponent implements HasLayoutSettings, LayoutSettings, OnI | |||
|
|
|||
| private getFiltersByView(view) { | |||
There was a problem hiding this comment.
Please rename to updateFiltersByView since methods does not 'get' anything
…array by changing the length to 0
wokeGit
pushed a commit
to wokeGit/argo
that referenced
this pull request
Nov 20, 2017
* Changing the filter value without re-assignment * Issue argoproj#40: Added fallback values for form in multiple-service-launch-panel * Issue argoproj#40: Added the template index for fallback val and changed the prop name to 'revision' * Issue argoproj#40: Passed in the template itself to provide the fallback val * axinternal/prod argoproj#444: Content of the filter is changed instead of reassigned upon tab-change * Removed comments * Removed white space * Issue argoproj#75: Changed the name of function and cleared the data array by changing the length to 0
wokeGit
pushed a commit
to wokeGit/argo
that referenced
this pull request
Nov 21, 2017
* Changing the filter value without re-assignment * Issue argoproj#40: Added fallback values for form in multiple-service-launch-panel * Issue argoproj#40: Added the template index for fallback val and changed the prop name to 'revision' * Issue argoproj#40: Passed in the template itself to provide the fallback val * axinternal/prod argoproj#444: Content of the filter is changed instead of reassigned upon tab-change * Removed comments * Removed white space * Issue argoproj#75: Changed the name of function and cleared the data array by changing the length to 0
wokeGit
pushed a commit
to wokeGit/argo
that referenced
this pull request
Nov 22, 2017
* Changing the filter value without re-assignment * Issue argoproj#40: Added fallback values for form in multiple-service-launch-panel * Issue argoproj#40: Added the template index for fallback val and changed the prop name to 'revision' * Issue argoproj#40: Passed in the template itself to provide the fallback val * axinternal/prod argoproj#444: Content of the filter is changed instead of reassigned upon tab-change * Removed comments * Removed white space * Issue argoproj#75: Changed the name of function and cleared the data array by changing the length to 0
icecoffee531
pushed a commit
to icecoffee531/argo-workflows
that referenced
this pull request
Jan 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The filter dropdown can stay open upon click (#75).