Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Retry with DAG. Fixes #7617 #7652

Merged
merged 2 commits into from
Jan 27, 2022
Merged

fix: Retry with DAG. Fixes #7617 #7652

merged 2 commits into from
Jan 27, 2022

Conversation

alexec
Copy link
Contributor

@alexec alexec commented Jan 26, 2022

Signed-off-by: Alex Collins alex_collins@intuit.com
Fixes #7617

Don't bother creating a PR until you've done this:

  • Run make pre-commit -B to fix codegen, lint, and commit message problems.

Create your PR as a draft.

  • Your PR needs to pass the required checks before it can be approved. If the check is not required (e.g. E2E tests) it
    does not need to pass.
  • Once required tests have passed, you can make it "Ready for review".
  • Say how how you tested your changes. If you changed the UI, attach screenshots.

Tips:

  • If changes were requested, and you've made them, then dismiss the review to get it looked at again.
  • Add you organization to USERS.md if you like.
  • You can ask for help!

Signed-off-by: Alex Collins <alex_collins@intuit.com>
@alexec alexec enabled auto-merge (squash) January 26, 2022 20:04
Copy link
Member

@terrytangyuan terrytangyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alexec alexec disabled auto-merge January 27, 2022 15:28
@alexec alexec merged commit 6a97a61 into argoproj:master Jan 27, 2022
@alexec alexec deleted the tmp branch January 27, 2022 15:28
@alexec alexec mentioned this pull request Jan 27, 2022
4 tasks
alexec added a commit that referenced this pull request Jan 27, 2022
Signed-off-by: Alex Collins <alex_collins@intuit.com>
@sarabala1979 sarabala1979 mentioned this pull request Mar 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Retrying a workflow that uses a DAG template and a loop does not retry the failed task/step.
2 participants