Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: update conlinmarc/hdfs to v2.2.1. Fixes #7816 #7826

Closed
wants to merge 1 commit into from
Closed

chore: update conlinmarc/hdfs to v2.2.1. Fixes #7816 #7826

wants to merge 1 commit into from

Conversation

yashvardhan-kukreja
Copy link

@yashvardhan-kukreja yashvardhan-kukreja commented Feb 8, 2022 •
edited
Loading

Signed-off-by: Yashvardhan Kukreja yash.kukreja.98@gmail.com

Fixes #7816

Updates:

  • colinmark/hdfs v1.1.4 to colinmark/hdfs/v2 v2.2.1
  • gopkg.in/jcmturner/gokrb5.v5 v5.3.0 to github.com/jcmturner/gokrb5/v8 v8.4.2

@yashvardhan-kukreja yashvardhan-kukreja force-pushed the issue-7816/update-to-colinmarc-hdfs-v2 branch 2 times, most recently from 21b1033 to 01ac2db Compare February 8, 2022 21:52
@yashvardhan-kukreja yashvardhan-kukreja changed the title update: conlinmarc/hdfs to v2.2.1. Fixes #7816 chore: update conlinmarc/hdfs to v2.2.1. Fixes #7816 Feb 8, 2022
@yashvardhan-kukreja
chore: update conlinmarc/hdfs to v2.2.1
7f53928 
Signed-off-by: Yashvardhan Kukreja <yash.kukreja.98@gmail.com>
@yashvardhan-kukreja yashvardhan-kukreja force-pushed the issue-7816/update-to-colinmarc-hdfs-v2 branch from 01ac2db to 7f53928 Compare February 8, 2022 21:59
terrytangyuan
terrytangyuan reviewed Feb 8, 2022
View reviewed changes
Copy link
Member

@terrytangyuan terrytangyuan left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you have HDFS setup to test out the changes?

blkperl
blkperl reviewed Feb 9, 2022
View reviewed changes
go.mod
@@ -77,7 +75,11 @@ require (
upper.io/db.v3 v3.6.3+incompatible
)

require github.com/go-git/go-git/v5 v5.3.0
require (
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this should be in the require block above instead of separate.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, I'll do so. The above go.mod related changes were the magic of go mod tidy :)

@sarabala1979
Copy link
Member

Have you tested with HDFS env? what is HDFS version?

@yashvardhan-kukreja
Copy link
Author

yashvardhan-kukreja commented Feb 10, 2022 •
edited
Loading

Hi @sarabala1979 @terrytangyuan , sorry I was pre-occupied a bit due to which I couldn't test against an existing HDFS setup.

I haven't played with the HDFS side of things associated argo-workflows so do you mind sharing template/guide/reference for hdfs<->argo-workflows setup which I can simulate locally and test this PR against ? :)

Is this a good place to start - https://github.com/argoproj/argo-workflows/blob/master/examples/hdfs-artifact.yaml ? :)

@blkperl
Copy link
Contributor

blkperl commented Feb 15, 2022

@dtaniwaki as the original contributor of hdfs support would you be able to help manually test this PR?

NikeNano
NikeNano reviewed Feb 21, 2022
View reviewed changes
workflow/artifacts/hdfs/hdfs.go
Comment on lines +10 to +11
credentialsv8 "github.com/jcmturner/gokrb5/v8/credentials"
keytabv8 "github.com/jcmturner/gokrb5/v8/keytab"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: previously the version of the package where not part of the name, what is the advantage of adding it?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No certain reason tbh, just kept it at that moment.
I can happily get rid of the v8s in the naming :)

PS: Apologies for the late reply, my github notifications clutter is a mess to deal with :P

@stale
Copy link

stale bot commented Mar 2, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the problem/stale This has not had a response in some time label Mar 2, 2022
@stale stale bot closed this Mar 12, 2022
@dtaniwaki
Copy link
Member

@blkperl Sorry for the late reply. I’m working in a different org and we don’t have HDFS right now. My current laptop doesn’t have it neither as I don’t use it now…

@agilgur5
Copy link
Member

agilgur5 commented Aug 8, 2023

Replaced by #11543

@agilgur5 agilgur5 added type/dependencies PRs and issues specific to updating dependencies go Pull requests that update Go dependencies and removed problem/stale This has not had a response in some time labels Aug 20, 2023
@agilgur5 agilgur5 added the solution/superseded This PR or issue has been superseded by another one (slightly different from a duplicate) label Feb 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blkperl blkperl blkperl left review comments

@terrytangyuan terrytangyuan terrytangyuan left review comments

@NikeNano NikeNano NikeNano left review comments

Assignees
No one assigned
Labels
go Pull requests that update Go dependencies solution/superseded This PR or issue has been superseded by another one (slightly different from a duplicate) type/dependencies PRs and issues specific to updating dependencies
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update colinmarc/hdfs to version 2.x
7 participants
@yashvardhan-kukreja @sarabala1979 @blkperl @dtaniwaki @agilgur5 @terrytangyuan @NikeNano