Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: executor plugin sidecar can be injected with sa secrets. #8104

Closed
wants to merge 1 commit into from

Conversation

whybeyoung
Copy link
Contributor

Signed-off-by: maybaby berlinsaint@126.com

Fixes #TODO

@whybeyoung
Copy link
Contributor Author

By my testing, i found that it create sidecar with automountServiceAccountToken set to false, this means no easy way to communitate with k8s api if want do sth in plugin.

@whybeyoung whybeyoung changed the title fix: executor plugin sidecar should can be inject sa secrets. fix: executor plugin sidecar can be injected with sa secrets. Mar 8, 2022
Copy link
Member

@simster7 simster7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor change otherwise LGTM

workflow/controller/agent.go Outdated Show resolved Hide resolved
@alexec
Copy link
Contributor

alexec commented Mar 9, 2022

This is not the correct approach for this. Unfortunatly, we do not want to share the same service account token between plugins as this would result in over-permissioing.

Instead, the service account token will need to be explicitly mounted on the plugin.

I'm going to close this PR, and open an issue laying out the solution.

@alexec alexec closed this Mar 9, 2022
@alexec
Copy link
Contributor

alexec commented Mar 9, 2022

Ok, so this shows you how to do secrets:

https://github.com/argoproj-labs/argo-workflows-slack-executor-plugin

Do we need to add docs?

@whybeyoung
Copy link
Contributor Author

whybeyoung commented Mar 20, 2022

Ok, so this shows you how to do secrets:

https://github.com/argoproj-labs/argo-workflows-slack-executor-plugin

Do we need to add docs?
I have read them, but i think we should reopen this or can you provide a better way to allow plugin initialize a kubeclient in the k8s pod, i think we should support plugin serviceaccount's rbac...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants