chore: remove unused code: validate.ValidateWorkflow() no longer sets wfConditions #9055
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ing it to clean up the code Signed-off-by: Julie Vogelman <julie_vogelman@intuit.com>
Signed-off-by: Julie Vogelman <julie_vogelman@intuit.com>
Signed-off-by: Julie Vogelman <julie_vogelman@intuit.com>
Signed-off-by: Julie Vogelman <julie_vogelman@intuit.com>
juliev0
commented
Jun 24, 2022
| @@ -106,16 +106,15 @@ func (args *FakeArguments) GetArtifactByName(name string) *wfv1.Artifact { | |||
| var _ wfv1.ArgumentsProvider = &FakeArguments{} | |||
|
|
|||
| // ValidateWorkflow accepts a workflow and performs validation against it. | |||
| func ValidateWorkflow(wftmplGetter templateresolution.WorkflowTemplateNamespacedGetter, cwftmplGetter templateresolution.ClusterWorkflowTemplateGetter, wf *wfv1.Workflow, opts ValidateOpts) (*wfv1.Conditions, error) { | |||
| wfConditions := &wfv1.Conditions{} | |||
| func ValidateWorkflow(wftmplGetter templateresolution.WorkflowTemplateNamespacedGetter, cwftmplGetter templateresolution.ClusterWorkflowTemplateGetter, wf *wfv1.Workflow, opts ValidateOpts) error { | |||
There was a problem hiding this comment.
this is the main change - to get rid of wfConditions which isn't used. Every other change is upstream from here.
tczhao
approved these changes
Jun 25, 2022
terrytangyuan
changed the title
terrytangyuan
approved these changes
Jun 25, 2022
reddymh
pushed a commit
to reddymh/argo-workflows
that referenced
this pull request
Jan 2, 2023
… wfConditions (argoproj#9055) * fix: validate.ValidateWorkflow() no longer sets wfConditions so removing it to clean up the code Signed-off-by: Julie Vogelman <julie_vogelman@intuit.com> * fix: unit tests Signed-off-by: Julie Vogelman <julie_vogelman@intuit.com> * fix: unit test Signed-off-by: Julie Vogelman <julie_vogelman@intuit.com> * fix: lint issue Signed-off-by: Julie Vogelman <julie_vogelman@intuit.com> Signed-off-by: Reddy <Rajshekar.Reddy@lowes.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
validate.ValidateWorkflow() no longer sets wfConditions so removing it to clean up the code
Signed-off-by: Julie Vogelman julie_vogelman@intuit.com