fix: a WorkflowTemplate doesn't need to define workflow-level input p… #9762
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…arameters Signed-off-by: Julie Vogelman <julie_vogelman@intuit.com>
Signed-off-by: Julie Vogelman <julie_vogelman@intuit.com>
Signed-off-by: Julie Vogelman <julie_vogelman@intuit.com>
alexec
approved these changes
Oct 10, 2022
juchaosong
pushed a commit
to juchaosong/argo-workflows
that referenced
this pull request
Nov 3, 2022
argoproj#9762) * fix: a WorkflowTemplate doesn't need to define workflow-level input parameters Signed-off-by: Julie Vogelman <julie_vogelman@intuit.com> * fix: accidental removal of code Signed-off-by: Julie Vogelman <julie_vogelman@intuit.com> * fix: accidental removal of code Signed-off-by: Julie Vogelman <julie_vogelman@intuit.com> Signed-off-by: Julie Vogelman <julie_vogelman@intuit.com> Signed-off-by: juchao <juchao@coscene.io>
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9711
resolveAllVariables() now has a check to determine if we are simply doing validation on a WorkflowTemplate