Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workflow level timeouts #848

Closed
vicaire opened this issue May 1, 2018 · 3 comments
Closed

Workflow level timeouts #848

vicaire opened this issue May 1, 2018 · 3 comments
Milestone

Comments

@vicaire
Copy link

vicaire commented May 1, 2018

Is this a BUG REPORT or FEATURE REQUEST?: FEATURE REQUEST

The following issue proposes to add an exponential backoff retry strategy at the container level:

#700

Would it also make sense to provide retry strategies for whole workflows?

Additionally, would it be possible to have timeouts for both containers and complete workflow so that (independently of retries) the container and/or workflows are cancelled if they do not complete within a specified duration?

In some cases, it might be useful to specify different timeouts for the case where the execution of the container takes too long, or the scheduling of the container takes too long (due to a lack of ressources in the cluster).

@jessesuen
Copy link
Member

jessesuen commented May 1, 2018

At the container level timeouts already possible via the activeDeadlineSeconds flag which we carry forward to the pod.

At the workflow level, we have built the groundwork for supporting this (but not yet fully implemented) through the /execution annotation which all workflow pod executors will look to, when deciding if a pod should terminate. Currently the only user of this annotation is daemon steps, but it was intended to support all types steps, not just daemon. Workflow level timeouts would be implemented by setting the deadline in this annotation

@vicaire
Copy link
Author

vicaire commented May 2, 2018

Sounds good. Thanks Jesse.

@jessesuen jessesuen added this to the v2.2 milestone Aug 6, 2018
@jessesuen jessesuen changed the title Retry and timeouts at the container and workflow level. Workflow level timeouts Aug 25, 2018
@vicaire
Copy link
Author

vicaire commented Aug 29, 2018

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants