Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Moved executor script capture to before artifact collection #1474

Closed
wants to merge 1 commit into from
Closed

Moved executor script capture to before artifact collection #1474

wants to merge 1 commit into from

Conversation

w3irdrobot
Copy link

Closes #1472

@CLAassistant
Copy link

CLAassistant commented Jul 12, 2019 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@xianlubird
Copy link
Member

xianlubird commented Jul 12, 2019 •
edited
Loading

@searsaw Pls sign the cla and could you provide a test case in code

@jessesuen jessesuen mentioned this pull request Jul 17, 2019
Closed
alexec
alexec requested changes Jan 2, 2020
View reviewed changes
Copy link
Contributor

@alexec alexec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can I please request some small changes:

  1. Can you sync with master and check all checks are green?
  2. Consider adding an e2e test in functional_test.go

@alexec alexec self-assigned this Jan 2, 2020
@alexec alexec removed the blocked label Jan 2, 2020
@alexec
Copy link
Contributor

alexec commented Apr 5, 2020

Adding wontfix as there has been no activity for 6 months.

@alexec alexec added the wontfix label Apr 5, 2020
@alexec
Copy link
Contributor

alexec commented May 13, 2020

No activity in 6 months - closing.

@alexec alexec closed this May 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexec alexec alexec requested changes

Assignees

@alexec alexec

Labels
type/bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Script results aren't saved if artifacts aren't found
5 participants
@w3irdrobot @CLAassistant @xianlubird @alexec @jessesuen