Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Correctly report version. Fixes #2264 #2268

Merged
merged 1 commit into from
Feb 20, 2020
Merged

Conversation

alexec
Copy link
Contributor

@alexec alexec commented Feb 20, 2020

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this is a chore.
  • The title of the PR is (a) conventional, (b) states what changed, and (c) suffixes the related issues number. E.g. "fix(controller): Updates such and such. Fixes #1234".
  • I have written unit and/or e2e tests for my change. PRs without these are unlike to be merged.
  • Optional. I've added My organization is added to the README.
  • I've signed the CLA and required builds are green.

Fixes #2264

@alexec alexec added this to the v2.5 milestone Feb 20, 2020
@alexec alexec requested a review from whynowy February 20, 2020 01:35
@codecov
Copy link

codecov bot commented Feb 20, 2020

Codecov Report

❗ No coverage uploaded for pull request base (master@79b09ed). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #2268   +/-   ##
=========================================
  Coverage          ?   11.36%           
=========================================
  Files             ?       71           
  Lines             ?    27986           
  Branches          ?        0           
=========================================
  Hits              ?     3182           
  Misses            ?    24399           
  Partials          ?      405

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 79b09ed...27e7053. Read the comment docs.

@alexec alexec marked this pull request as ready for review February 20, 2020 01:53
@alexec
Copy link
Contributor Author

alexec commented Feb 20, 2020

This PR can be merged as soon as approved, but should be back-ported to v2.5.

@alexec alexec merged commit acf37c2 into argoproj:master Feb 20, 2020
@alexec alexec deleted the fix-2264 branch February 20, 2020 03:52
alexec added a commit that referenced this pull request Feb 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorrect version info in release v2.5.0
2 participants