Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(cli): Migrate argo wait to use API client. See #2116 #2282

Merged
merged 15 commits into from
Feb 25, 2020
Merged

chore(cli): Migrate argo wait to use API client. See #2116 #2282

merged 15 commits into from
Feb 25, 2020

Conversation

alexec
Copy link
Contributor

@alexec alexec commented Feb 20, 2020 •
edited
Loading

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this is a chore.
  • The title of the PR is (a) conventional, (b) states what changed, and (c) suffixes the related issues number. E.g. "fix(controller): Updates such and such. Fixes #1234".
  • I have written unit and/or e2e tests for my change. PRs without these are unlike to be merged.
  • Optional. I've added My organization is added to the README.
  • I've signed the CLA and required builds are green.

See #2116.
Please merge this as soon as builds are green and it is approved.

@alexec alexec added this to the Backlog milestone Feb 20, 2020
@alexec alexec linked an issue Feb 20, 2020 that may be closed by this pull request
Migrate CLI workflow commands to use apiclient.Client #2116
Closed
15 tasks
@alexec alexec mentioned this pull request Feb 20, 2020
Closed
15 tasks
@alexec alexec changed the title chore(cli): Migrate argo watch to use API client. See #2116 chore(cli): Migrate argo wait to use API client. See #2116 Feb 20, 2020
@codecov
Copy link

codecov bot commented Feb 21, 2020 •
edited
Loading

Codecov Report

Merging #2282 into master will increase coverage by 1.58%.
The diff coverage is 22.22%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2282      +/-   ##
==========================================
+ Coverage   11.46%   13.04%   +1.58%     
==========================================
  Files          71       70       -1     
  Lines       27791    24431    -3360     
==========================================
+ Hits         3187     3188       +1     
+ Misses      24199    20838    -3361     
  Partials      405      405
Impacted Files Coverage Δ
persist/sqldb/offload_node_status_repo.go 3.9% <ø> (ø) ⬆️
server/workflow/workflow_server.go 32.96% <0%> (-1.75%) ⬇️
...erver/workflowtemplate/workflow_template_server.go 54% <100%> (ø) ⬆️
workflow/controller/operator.go 60.21% <100%> (+0.12%) ⬆️
workflow/controller/steps.go 60.46% <20%> (-1.94%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 32c2055...075ad3c. Read the comment docs.

golangcibot
golangcibot reviewed Feb 22, 2020
View reviewed changes
pkg/apiclient/watch-intermediary.go Outdated Show resolved Hide resolved
pkg/apiclient/watch-intermediary.go Show resolved Hide resolved
pkg/apiclient/watch-intermediary.go Outdated Show resolved Hide resolved
@alexec alexec marked this pull request as ready for review February 24, 2020 16:48
sarabala1979
sarabala1979 reviewed Feb 24, 2020
View reviewed changes
pkg/apiclient/argo-kube-client.go
@@ -43,7 +45,7 @@ func newArgoKubeClient(clientConfig clientcmd.ClientConfig) (context.Context, Cl
}

func (a *argoKubeClient) NewWorkflowServiceClient() workflowpkg.WorkflowServiceClient {
return &argoKubeWorkflowServiceClient{workflowserver.NewWorkflowServer(sqldb.ExplosiveOffloadNodeStatusRepo)}
return &argoKubeWorkflowServiceClient{workflowserver.NewWorkflowServer(argoKubeOffloadNodeStatusRepo)}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't see the benefit of this change. are you using the same variable anywhere?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

in another PR I think - I did wonder if we should actually just log the error rather than explode- thoughts

@sarabala1979
Copy link
Member

watch and wait hangs on kubeclient even after workflow completes.

image

image

@alexec
Copy link
Contributor Author

alexec commented Feb 24, 2020

watch and wait hangs on kubeclient even after workflow completes.

image

image

Let me investigate.

@alexec
Copy link
Contributor Author

alexec commented Feb 24, 2020

ok, so repro using unset ARGO_SERVER

@sarabala1979
Copy link
Member

argo watch is behaving differently for Kube client and api client I believe offloadnodestatus is always enabled for small workflows instead of enabling once it reached etcd max size.

Kubeclient
image

API client
image

@alexec alexec merged commit 5c3d9cf into argoproj:master Feb 25, 2020
@alexec alexec deleted the cli-watch branch February 25, 2020 20:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@golangcibot golangcibot golangcibot left review comments

@sarabala1979 sarabala1979 sarabala1979 approved these changes

Assignees

@sarabala1979 sarabala1979

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Migrate CLI workflow commands to use apiclient.Client
3 participants
@alexec @sarabala1979 @golangcibot