Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Tidy after make codegen #2332

Merged
merged 1 commit into from
Mar 2, 2020
Merged

Conversation

simster7
Copy link
Member

Add test to ensure that make codegen was run

@codecov
Copy link

codecov bot commented Feb 28, 2020

Codecov Report

❗ No coverage uploaded for pull request base (master@62e6db8). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #2332   +/-   ##
=========================================
  Coverage          ?   13.38%           
=========================================
  Files             ?       70           
  Lines             ?    24232           
  Branches          ?        0           
=========================================
  Hits              ?     3244           
  Misses            ?    20579           
  Partials          ?      409

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 62e6db8...4b93bce. Read the comment docs.

@simster7 simster7 changed the title chore: Add test for make codegen chore: Tidy after make codegen Mar 2, 2020
Copy link
Contributor

@alexec alexec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you check to see how much longer make codegen takes?

@simster7
Copy link
Member Author

simster7 commented Mar 2, 2020

The time increase is negligible

@simster7 simster7 merged commit c28731b into argoproj:master Mar 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants