Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: Split e2e tests to make them faster #4404

Merged
merged 11 commits into from
Oct 28, 2020
Merged

ci: Split e2e tests to make them faster #4404

merged 11 commits into from
Oct 28, 2020

Conversation

alexec
Copy link
Contributor

@alexec alexec commented Oct 27, 2020 •
edited
Loading

Signed-off-by: Alex Collins alex_collins@intuit.com

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this is a chore.
  • The title of the PR is (a) conventional, (b) states what changed, and (c) suffixes the related issues number. E.g. "fix(controller): Updates such and such. Fixes #1234".
  • My organization is added to USERS.md.
  • I've signed the CLA.
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My builds are green. Try syncing with master if they are not.

I see that we are having builds fail because they take over 20m to complete. This splits the e2e tests into two parallel groups.

Changes

  1. Stop the test job from building the UI.
  2. Tag CLI E2E tests with cli so we can have make test-cli.

Outcomes

  1. test job runs 4m faster
  2. whole build finishes in about 11m

@alexec
ci: Fix CI builds
94cddfd 
Signed-off-by: Alex Collins <alex_collins@intuit.com>
@alexec
fast: M Makefile
b448bab 
Signed-off-by: Alex Collins <alex_collins@intuit.com>
@alexec
fast: M .github/workflows/ci-build.yaml
20de6cd 
Signed-off-by: Alex Collins <alex_collins@intuit.com>
@alexec
fast: M .golangci.yml
2fcb7fe 
Signed-off-by: Alex Collins <alex_collins@intuit.com>
@alexec
fast: M .github/workflows/ci-build.yaml
10ca408 
Signed-off-by: Alex Collins <alex_collins@intuit.com>
@alexec
fast: M go.mod
d5b9380 
Signed-off-by: Alex Collins <alex_collins@intuit.com>
@alexec
ok
d35ee80 
Signed-off-by: Alex Collins <alex_collins@intuit.com>
@alexec alexec changed the title ci: Fix CI builds ci: Split e2e tests to make them faster Oct 27, 2020
@alexec alexec marked this pull request as ready for review October 27, 2020 23:24
@alexec alexec requested a review from simster7 October 27, 2020 23:28
simster7
simster7 reviewed Oct 28, 2020
View reviewed changes
test/e2e/metrics_test.go Outdated Show resolved Hide resolved
@alexec
Merge branch 'master' into fast
46e1c92 
Signed-off-by: Alex Collins <alex_collins@intuit.com>
@alexec
fast: M test/e2e/argo_server_test.go
fe8cfb4 
Signed-off-by: Alex Collins <alex_collins@intuit.com>
@alexec
ok
ed506dc 
Signed-off-by: Alex Collins <alex_collins@intuit.com>
@alexec
fast: M test/e2e/http_logger.go
c56ea38 
Signed-off-by: Alex Collins <alex_collins@intuit.com>
simster7
simster7 approved these changes Oct 28, 2020
View reviewed changes
Copy link
Member

@simster7 simster7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rubber-stamp

@alexec alexec merged commit b34b91f into argoproj:master Oct 28, 2020
@alexec alexec deleted the fast branch October 28, 2020 16:43
alexcapras pushed a commit to alexcapras/argo that referenced this pull request Nov 12, 2020
@alexec @alexcapras
ci: Split e2e tests to make them faster (argoproj#4404)
b6f86c7 
Signed-off-by: Alex Collins <alex_collins@intuit.com>

* ok

Signed-off-by: Alex Collins <alex_collins@intuit.com>
Signed-off-by: Alex Capras <alexcapras@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simster7 simster7 simster7 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alexec @simster7