fix(controller): Fixed workflow stuck with mutex lock #4744
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Saravanan Balasubramanian <sarabala1979@gmail.com>
sarabala1979
commented
Dec 15, 2020
| i, holder := ms.GetHolding(lockKey) | ||
| items := strings.Split(holderKey, "/") | ||
| holdingName := items[len(items)-1] | ||
| if i >= 0 && holder.Holder == holdingName { |
There was a problem hiding this comment.
This check will make sure who is requesting the mutex release
sarabala1979
commented
Dec 15, 2020
| @@ -93,7 +93,11 @@ func (woc *wfOperationCtx) executeSteps(nodeName string, tmplCtx *templateresolu | |||
|
|
|||
| sgNode := woc.executeStepGroup(stepGroup.Steps, sgNodeName, &stepsCtx) | |||
|
|
|||
| if !sgNode.Fulfilled() { | |||
| if sgNode.Fulfilled() { | |||
There was a problem hiding this comment.
If the step template has mutex lock and will not invoke execute template to release the lock if child nodes are completed. It. has to be handled here
Eg:
- name: main-function
synchronization:
mutex:
name: config
steps:
- - name: check
template: main-command
- - name: check1
template: main-command
simster7
suggested changes
Dec 15, 2020
Signed-off-by: Saravanan Balasubramanian <sarabala1979@gmail.com>
simster7
suggested changes
Dec 15, 2020
simster7
approved these changes
Dec 15, 2020
Signed-off-by: Saravanan Balasubramanian <sarabala1979@gmail.com>
simster7
pushed a commit
that referenced
this pull request
Dec 15, 2020
Signed-off-by: Saravanan Balasubramanian <sarabala1979@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Saravanan Balasubramanian sarabala1979@gmail.com
Checklist:
Fixes #4703