Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Create sig-security #116

Merged
merged 7 commits into from
Dec 15, 2022
Merged

Conversation

todaywasawesome
Copy link
Contributor

Team, we established sig-security a few months ago, are holding regular meetings, and are taking action. This PR is to begin the process of formalizing sig-security.

Signed-off-by: Dan Garfield <dan@codefresh.io>
## Security Policy and Reporting Issues
Argo Project security policy and instructions for reporting issues is availabile [here](https://github.com/argoproj/argoproj/blob/master/SECURITY.md).

## Members
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I recommend keeping the members as the maintainers and also engineers. I haven't seen Sasha once in any Argo meetings. I am hesitant to agree to grant the privileges and membership here.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To be clear and comprehensive, no membership doesn't prevent interested individuals and parties to participate in the discussion, putting effort, resources. However, I feel only the contributors are more entitled to the membership as it could be translated to make/represent some key decisions for the communities, and those people who are doing the day-to-day coding, should be trusted more in the security context.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sasha has joined several of the sig-security meetings and contributed there.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tend to agree with the concerns of @wanghong230. However, I also think it's great to have someone with a more external (and specialized) point of view (e.g. to see things that we as maintainers do not see due to "operational blindness" or are just not aware of).

I don't know, but how do we think suggestions from the SIG security will be operationalized? Will they run through maintainer approval (like other important change requests do), or does the SIG have something like an "override" on that? In the former case, I see no problems with having someone "external" on board. In the latter case, how about having something like an "Adivsory council" or "Advisory board" without voting power within the SIG?


## Security Policy and Reporting Issues
Argo Project security policy and instructions for reporting issues is availabile [here](https://github.com/argoproj/argoproj/blob/master/SECURITY.md).

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
## Membership Requirements
- Must be an Argo project maintainer from the current list (https://github.com/argoproj/argoproj/blob/master/MAINTAINERS.md).
- Must have shown competency in discovering, solving, and communicating in the project security context.
- Must have shown a proven record of solid coding development.
- Must represent the open-source community’s best interest with a vendor-neutral practice.
- The membership will be revisited every calendar year.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The team agrees on the maintainer requirement.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Line 13/14: replace to "The maintainers to decide the membership." "Define a process for adding/removing."

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Open questions:

  • How is membership determined?
  • What is the responsibility of the members?

Copy link
Member

@jannfis jannfis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few nits on formatting :)

sigs/sig-security/README.md Outdated Show resolved Hide resolved
Argo Sig Security is focused on improving security across the Argo project, promoting best practices, and ensuring a high level of security for end users.

## Meetings
Sig security meetings include public and non-public sections and are held twice monthly. Meetings can be found in the [Argo Project public calendar](https://calendar.google.com/calendar/embed?src=argoproj%40gmail.com&ctz=America%2FDenver).
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Sig security meetings include public and non-public sections and are held twice monthly. Meetings can be found in the [Argo Project public calendar](https://calendar.google.com/calendar/embed?src=argoproj%40gmail.com&ctz=America%2FDenver).
SIG security meetings include public and non-public sections and are held twice monthly. Meetings can be found in the [Argo Project public calendar](https://calendar.google.com/calendar/embed?src=argoproj%40gmail.com&ctz=America%2FDenver).

sigs/sig-security/README.md Outdated Show resolved Hide resolved
sigs/sig-security/README.md Show resolved Hide resolved
sigs/sig-security/README.md Outdated Show resolved Hide resolved
@todaywasawesome todaywasawesome changed the title Create sig-security feat: Create sig-security Apr 20, 2022
todaywasawesome and others added 5 commits April 20, 2022 14:50
Signed-off-by: Dan Garfield <dan@codefresh.io>

Co-authored-by: jannfis <jann@mistrust.net>
Signed-off-by: Dan Garfield <dan@codefresh.io>

Co-authored-by: jannfis <jann@mistrust.net>
Signed-off-by: Dan Garfield <dan@codefresh.io>

Co-authored-by: jannfis <jann@mistrust.net>
Signed-off-by: Dan Garfield <dan@codefresh.io>

Co-authored-by: jannfis <jann@mistrust.net>
Signed-off-by: Dan Garfield <dan@codefresh.io>

Co-authored-by: jannfis <jann@mistrust.net>
@edlee2121
Copy link
Contributor

Can we merge/close this?

Copy link
Contributor

@sbose78 sbose78 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be good to be taken in?

@edlee2121
Copy link
Contributor

Any further comments?

@sbose78
Copy link
Contributor

sbose78 commented Dec 15, 2022

Assuming the meetings are still taking place, I'm going to take this in so that the same is reflected in our community/governance docs. Please feel free to update this doc when needed.

@sbose78 sbose78 merged commit d388873 into argoproj:master Dec 15, 2022
## Members
| Name | Company | Email |
|--------|------|------|
| Alexander Matyushentsev | Intuit | |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The org name needs to change here :)

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Outtuit, Inkuity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants