Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Update news with move from CLA to DCO #18

Merged
merged 1 commit into from
Oct 29, 2020
Merged

Conversation

edlee2121
Copy link
Contributor

Signed-off-by: Edward Lee edward_lee@intuit.com

README.md Outdated
* https://github.com/apps/dco/
Please start signing off your contributions by doing ONE of the following:
* Run `git config commit.gpgsign true` in your argo repo to automatically signoff future commits.
* Use `git commit -s ...` with each commit to add signoff.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

error: cannot run gpg: No such file or directory

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor Author

@edlee2121 edlee2121 Oct 22, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alex, you don't need gpg. You should disable that. It's disabled by default

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

when I followed those instructions, it worked

@@ -6,6 +6,13 @@

## News

Argo Project is moving from CLA to DCO as a more contributor friendly way to track contributions.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

how is this more friendly?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The DCO is much shorter to read and understand.

README.md Outdated Show resolved Hide resolved
@edlee2121 edlee2121 force-pushed the bootstrap3 branch 4 times, most recently from 152f600 to 3a1a96d Compare October 22, 2020 23:26
Signed-off-by: Edward Lee <edward_lee@intuit.com>
@edlee2121
Copy link
Contributor Author

@alexec , are you good with the PR?

@alexec
Copy link
Contributor

alexec commented Oct 29, 2020

It is fine. It is a bit more work for developers, as they must sign all commits, but no one has complained.

Can I ask you disable CLA at some point?

@edlee2121
Copy link
Contributor Author

edlee2121 commented Oct 29, 2020

Thanks. When we switch over in about a week or two, CLA will be disabled.
Please approve PR.

@edlee2121 edlee2121 merged commit 6bc5ddf into master Oct 29, 2020
@alexmt alexmt deleted the bootstrap3 branch October 29, 2020 22:02
@sbose78 sbose78 added this to Done in Governance Backlog Mar 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

2 participants