Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(sig): add scalability group #192

Merged
merged 16 commits into from
May 3, 2023

Conversation

morey-tech
Copy link
Contributor

@morey-tech morey-tech commented Mar 2, 2023

Create the Scalability SIG based on the discussion in the community meeting on 2023-03-01 about docs: add scalability benchmarking proposal #12662.

Todo, pending approval of this PR:

  • Create the argo-sig-scalability channel on CNCF Slack.
  • Add the SIG Scalability meetings to the argoproj calendar.
  • Create a Google Doc for the meetings and add the argoproj google account as the owner.
  • Add GitHub App to Slack channel to post notifications for the type:scalability label.

Signed-off-by: Nicholas Morey <nicholas@morey.tech>
Signed-off-by: Nicholas Morey <nicholas@morey.tech>
Signed-off-by: Nicholas Morey <nicholas@morey.tech>
@morey-tech morey-tech marked this pull request as ready for review March 2, 2023 16:45
morey-tech and others added 4 commits March 2, 2023 15:32
Co-authored-by: jannfis <jann@mistrust.net>
Signed-off-by: Nicholas Morey <nicholas@morey.tech>
Signed-off-by: Nicholas Morey <nicholas@morey.tech>
Signed-off-by: Nicholas Morey <nicholas@morey.tech>
Signed-off-by: Nicholas Morey <nicholas@morey.tech>
@hblixt
Copy link
Collaborator

hblixt commented Mar 3, 2023

To create a SIG, you need a maintainer appointed secretary/coordinator, (https://github.com/argoproj/argoproj/blob/master/community/SIG-GOVERNANCE.md). That need to be figured out and the person appointed by the Argo maintainers before this PR can be merged and the SIG created
As there are also plans for an argo-labs repos, a project onboarding ticket is needed (https://github.com/argoproj/argoproj/blob/master/proposals/001-project-onboarding.md)
It might also be worth considering not intertwining the SIG and the repos too much e.g. the SIG has a broader charter around Argo scalability, whereas the argo-labs tools repos is focused on implementation but has an ownership/membership that's different than the SIG itself.

Signed-off-by: Nicholas Morey <nicholas@morey.tech>
Signed-off-by: Nicholas Morey <nicholas@morey.tech>
Signed-off-by: Nicholas Morey <nicholas@morey.tech>
@morey-tech
Copy link
Contributor Author

morey-tech commented Mar 4, 2023

Thank you, @hblixt, for your review and guidance!

To create a SIG, you need a maintainer appointed secretary/coordinator, (https://github.com/argoproj/argoproj/blob/master/community/SIG-GOVERNANCE.md). That needs to be figured out, and the person appointed by the Argo maintainers before this PR can be merged and the SIG created

I'm happy to take on the coordinator role for the Scalability SIG. What is the appointment process, or where is best to reach out for an approval from the Maintainers? It would be good to add it to the SIG README, I could add a Role column in the Members table.

As there are also plans for an argo-labs repos, a project onboarding ticket is needed (https://github.com/argoproj/argoproj/blob/master/proposals/001-project-onboarding.md) It might also be worth considering not intertwining the SIG and the repos too much e.g. the SIG has a broader charter around Argo scalability, whereas the argo-labs tools repos is focused on implementation but has an ownership/membership that's different than the SIG itself.

Understood. The repo for the scalability benchmarking tooling will not be limited to the Scalability SIG and vice versa.

@hblixt
Copy link
Collaborator

hblixt commented Mar 6, 2023

Thank you, @hblixt, for your review and guidance!

I'm happy to take on the coordinator role for the Scalability SIG. What is the appointment process, or where is best to reach out for an approval from the Maintainers? It would be good to add it to the SIG README, I could add a Role column in the Members table.

I have added it as a topic to the Argo Maintainer meeting on 3/7. Would be good if you could be there @morey-tech

@morey-tech
Copy link
Contributor Author

I have added it as a topic to the Argo Maintainer meeting on 3/7. Would be good if you could be there @morey-tech

Great, thanks! I'll be there.

Signed-off-by: Nicholas Morey <nicholas@morey.tech>
@morey-tech
Copy link
Contributor Author

morey-tech commented Mar 7, 2023

Based on the conversation in the Argo Maintainers Meeting on 2023-03-07; to promote engagement from the broader community before proceeding with the formal approval, we will move forward with holding the SIG Scalability meetings, along with posting in the CNCF Slack channel.

In support of this, I'll arrange to create the meeting log document, Slack channel, and schedule the recurring meeting on the argoproj calendar.

@csantanapr
Copy link
Member

@morey-tech

In support of this, I'll arrange to create the meeting log document, Slack channel, and schedule the recurring meeting on the argoproj calendar.

your a star ⭐

Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
Signed-off-by: Nicholas Morey <nicholas@morey.tech>
Signed-off-by: Nicholas Morey <nicholas@morey.tech>
Copy link
Contributor

@vsethi vsethi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Request for membership

sigs/sig-scalability/README.md Show resolved Hide resolved
morey-tech and others added 2 commits April 12, 2023 09:12
Co-authored-by: Vikram Sethi <vsethi.github@gmail.com>
Signed-off-by: Nicholas Morey <nicholas@morey.tech>
Signed-off-by: Nicholas Morey <nicholas@morey.tech>
@morey-tech
Copy link
Contributor Author

The Scalability SIG was officially approved during the maintainer's meeting today. This PR is ready to be merged.

Copy link
Collaborator

@hblixt hblixt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved as per the maintainer meeting 5/2.
Looking forward to lots of valuable content from this SIG!

@crenshaw-dev crenshaw-dev merged commit f8783dc into argoproj:master May 3, 2023
1 check passed
@morey-tech morey-tech deleted the sig-scalability branch May 3, 2023 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

10 participants