Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added support for impersonation in the kubectl #534

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Added support for impersonation in the kubectl #534

wants to merge 1 commit into from

Conversation

anandf
Copy link
Contributor

@anandf anandf commented Jul 26, 2023

This change is for propogating impersonation related configurations to the kubeconfig used for executing the kubectl command.

@codecov
Copy link

codecov bot commented Jul 26, 2023 •
edited

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 54.68%. Comparing base (5fd9f44) to head (d6d94bc).
Report is 6 commits behind head on master.

❗ Current head d6d94bc differs from pull request most recent head 8e08d4a

Please upload reports for the commit 8e08d4a to get more accurate results.

Files Patch % Lines
pkg/utils/kube/resource_ops.go 0.00% 3 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master     #534      +/-   ##
==========================================
- Coverage   54.71%   54.68%   -0.04%     
==========================================
  Files          41       41              
  Lines        4834     4837       +3     
==========================================
  Hits         2645     2645              
- Misses       1977     1980       +3     
  Partials      212      212

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sonarcloud
Copy link

sonarcloud bot commented Jul 26, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@anandf anandf marked this pull request as draft August 3, 2023 12:56
@anandf anandf marked this pull request as ready for review October 31, 2023 16:22
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Feb 7, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

ishitasequeira
ishitasequeira approved these changes Apr 8, 2024
View reviewed changes
Copy link
Member

@ishitasequeira ishitasequeira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!

@anandf anandf force-pushed the support_impersonate branch 2 times, most recently from 4339b37 to 5eca797 Compare April 29, 2024 08:55
@anandf
Added support for impersonation in the kubectl
8e08d4a 
Signed-off-by: anandf <anjoseph@redhat.com>
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented May 23, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
8.1% Duplication on New Code

See analysis details on SonarCloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ishitasequeira ishitasequeira ishitasequeira approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@anandf @ishitasequeira