chore: Add IgnoreResourceStatusField field to DiffOptions

[darshanime]

Can be used to ignore /status of the objects.
See argoproj/argo-cd#3754

[codecov]

Codecov Report

Merging #60 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #60   +/-   ##
=======================================
  Coverage   52.49%   52.49%           
=======================================
  Files          25       25           
  Lines        2585     2585           
=======================================
  Hits         1357     1357           
  Misses       1100     1100           
  Partials      128      128           

Impacted Files	Coverage Δ
pkg/diff/diff.go	59.63% <ø> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fb2ec13...3814206. Read the comment docs.

[sonarcloud]

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities (and 0 Security Hotspots to review)
0 Code Smells

No Coverage information
0.0% Duplication

[jannfis]

I think we should also provide a list of valid options for IgnoreResourceStatusField in something like an additional type, which in turn should also be used in the ArgoCD consumer. What do you think?

[darshanime]

I thought about it, but then thought not all consumers of this library would want to abide by that classification. If it's a string field, they can use it in a way that fits their semantics.

What do you think?

[jannfis]

Hm yes, that's a good point.

But now I'm also thinking about whether we should rather move the whole functionality into gitops-engine, instead of making it an argo-cd feature with a "dead" switch in gitops-engine. Or should we move the diff options (and its current features) to argo-cd?

[alexmt]

Instead of adding an unused field, I would suggest adding data structure that inherits DiffOptions from gitops engine and adds IgnoreResourceStatusField.

[darshanime]

This can be done in argo-cd, can I close this PR in that case?

[alexmt]

sure @darshanime . lets close this PR and implement changes in Argo CD

[darshanime]

cool, thanks for comments, closing