feat: support email SendHtml #30
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #30 +/- ##
==========================================
- Coverage 46.84% 46.71% -0.13%
==========================================
Files 26 26
Lines 1456 1460 +4
==========================================
Hits 682 682
- Misses 626 630 +4
Partials 148 148
Continue to review full report at Codecov.
|
alexmt
requested changes
May 27, 2021
pkg/services/email.go
Outdated
| @@ -56,6 +56,7 @@ type EmailOptions struct { | |||
| Username string `json:"username"` | |||
| Password string `json:"password"` | |||
| From string `json:"from"` | |||
| SendHtml bool `json:"sendHtml"` | |||
There was a problem hiding this comment.
Can you change it to just html please? I think send is redundant.
There was a problem hiding this comment.
Thank you for reviewing.
I was thinking whether to use html or sendHtml, indeed it is redundant so I have changed to html.
Signed-off-by: Ryota Sakamoto <sakamo.ryota+github@gmail.com>
ryota-sakamoto
force-pushed
the
support-html-email
branch
from
25a79a9
to
4a91a7e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Ryota Sakamoto sakamo.ryota+github@gmail.com