Use more up-to-date and comprehensive JSONPath library

[b-erdem]

Recently we noticed that Argo Workflow doesn't support some JSONPath expression to extract some values from inputs. After digging a bit we found that current JSONPath library used by Argo is outdated and it does support only a fraction of the spec. After looking around for better JSONPath libraries I found this one that works for the all expressions I have tried so far: github.com/evilmonkeyinc/jsonpath

If you're also curious about other libraries you can see a comparison here but keep in mind that it's either outdated or incorrect: https://asaiyusuke.github.io/jsonpath/cburgmer-json-path-comparison/docs/index.html

Because I tried some of the JSONPath libraries listed there, including the one written by the author of the post above and most of the expressions in the comparison table didn't work.

• As I see these changes don't cause any issue or break existing functionality.

• I have added some test cases to cover more complex expressions.

Please let me know if there's any mistake or something I'm missing when opening a PR here.

[b-erdem]

@agilgur5 Hello Anton, I opened this PR to change the JSONPath library.

[agilgur5]

For posterity, this is a follow-up from Slack

[agilgur5]

LGTM. Thanks for adding tests too!

[agilgur5]

I looked through some of the Go JSONPath libraries as well and noticed that several were unmaintained (and incomplete) unfortunately 😕
The new library in this PR is not that popular, but none of them really were as far as I could tell. This one does have some decent docs though

[sonarcloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
0.0% Duplication

[agilgur5]

@b-erdem could you make a PR to Workflows to update this dep now?

[b-erdem]

@b-erdem could you make a PR to Workflows to update this dep now?

Hi, thanks for merging it! I can open a PR on Workflows in a few hours once I’m at home. Does that work?

[agilgur5]

Yea no rush or anything

[agilgur5]

@b-erdem just a friendly reminder that the full update still requires a PR to Workflows

[b-erdem]

@agilgur5 Thanks for the reminder. I’m working on it. It turned out I needed to make a few changes on the main repo. Just updating the dependencies was not enough. I’ll just open a PR and we can discuss the changes I made there.