New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The hosts in istio example does not allow external access #11

Closed

huikang opened this issue Apr 14, 2021 · 1 comment

Member

huikang commented Apr 14, 2021

I install the istio example in a local k8s cluster. After installation, pointing the browser to localhost shows an empty page.

After applying the following changes, I can see the application page at localhost. Shall we fix this?

diff --git a/examples/istio/virtualservice.yaml b/examples/istio/virtualservice.yaml
index 148496c..00dac8c 100644
--- a/examples/istio/virtualservice.yaml
+++ b/examples/istio/virtualservice.yaml
@@ -6,8 +6,9 @@ spec:
   gateways:
   - istio-rollout-gateway
   hosts:
-  - istio-rollout.apps.argoproj.io
-  - istio-rollout.local
+  - "*"

The text was updated successfully, but these errors were encountered:

huikang closed this as completed

markvandenbosch commented Apr 1, 2022

@huikang Why is this issue closed without applying the fix?
This change would make the example usable without changing the virtual service locally.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment