Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How to enable github check? #423

Closed
shaodahong opened this issue Oct 23, 2020 · 8 comments
Closed

How to enable github check? #423

shaodahong opened this issue Oct 23, 2020 · 8 comments

Comments

@shaodahong
Copy link
Contributor

shaodahong commented Oct 23, 2020

As a user,

Motivation

In my see, argos support github app to intuitive view result, like

image

and authorized argos repository, relate pr ant-design/ant-design#24475, but i can't find argos check

Argos builds

https://www.argos-ci.com/ant-design/ant-design/builds

@gregberge thanks

Detail

@yoyo837
Copy link

yoyo837 commented Oct 27, 2020

Is the can be closed?

@shaodahong
Copy link
Contributor Author

no, fork repository not effect

@shaodahong
Copy link
Contributor Author

@gregberge Check status depend branch name or commit id or pull id?

@gregberge
Copy link
Member

@shaodahong this is the commit, it should work out of the box if everything is correctly configured. What is exactly the problem?

@shaodahong
Copy link
Contributor Author

ant-design/ant-design#27394

Argos build
https://www.argos-ci.com/ant-design/ant-design/builds/57

in my see, it's upload correctly, but i can't find the check status

@shaodahong
Copy link
Contributor Author

shaodahong commented Oct 27, 2020

I use the azure pipeline, It only happens in the fork repository, maybe azure pipeline commit id is not correctly, but everything looks normal

Azure pipeline doc

image

@shaodahong
Copy link
Contributor Author

Thanks for you reply, and it's resolved, reason is azure commit id it merge id, not commit id, i find a outside doc var System.PullRequest.SourceCommitId, it's good to me

@gregberge
Copy link
Member

Thanks for you reply, and it's resolved, reason is azure commit id it merge id, not commit id, i find a outside doc var System.PullRequest.SourceCommitId, it's good to me

Good!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants