test: demo -> ui test #24475

shaodahong · 2020-05-26T11:27:20Z

🤔 This is a ...

🔗 Related issue link

💡 Background and solution

📝 Changelog

Language	Changelog
🇺🇸 English
🇨🇳 Chinese

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

Doc is updated/provided or not needed
Demo is updated/provided or not needed
TypeScript definition is updated/provided or not needed
Changelog is provided or not needed

ant-design-bot · 2020-05-26T11:30:45Z

ant-design-bot · 2020-05-26T11:30:50Z

afc163 · 2020-05-26T11:32:26Z

git 里面存 png 的话，感觉会让这个仓库 git history 爆炸，现在 clone 下来已经很慢了。

shaodahong · 2020-05-26T11:37:55Z

git 里面存 png 的话，感觉会让这个仓库 git history 爆炸，现在 clone 下来已经很慢了。

还可以感觉，多了大约 5M

yoyo837 · 2020-05-26T12:09:18Z

commit 会累积

shaodahong · 2020-05-26T12:25:12Z

这倒是问题，或者使用 Git LFS

afc163 · 2020-05-26T12:54:40Z

能不能存 cdn，或者 base64？

shaodahong · 2020-05-26T13:49:31Z

base64 倒是可以试一试

yoyo837 · 2020-05-27T01:05:11Z

base64比原尺寸大30%多，不过不知道和直接二进制文件对仓库历史堆积的影响有何区别。

shaodahong · 2020-05-27T02:04:24Z

嗯，昨晚调研了下发现还是 Git LFS 主流的方案，不过也有问题，和 husky 不兼容……，进了连环套……

afc163 · 2020-07-29T03:54:45Z

试试能不能用 https://www.argos-ci.com/

https://www.argos-ci.com/mui-org/material-ui/builds/2768

shaodahong · 2020-07-29T11:44:54Z

试了下还行

Demo:
https://www.argos-ci.com/shaodahong/ant-design/builds/4

需要配置下，我没有仓库权限 @afc163

07akioni · 2020-07-29T12:38:24Z

大家认为搞这个必要性很高吗？比如说之前出现了一些问题 snapshot 解决不了的

afc163 · 2020-07-29T13:35:23Z

https://www.argos-ci.com/ant-design/ant-design/builds

shaodahong · 2020-07-30T05:28:12Z

/rebase

codesandbox-ci · 2020-07-30T05:43:07Z

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 1b4c255:

Sandbox	Source
antd reproduction template	Configuration

shaodahong · 2020-07-30T15:42:50Z

大家认为搞这个必要性很高吗？比如说之前出现了一些问题 snapshot 解决不了的

@07akioni 还是有必要的，但是优先级倒不是很高，咱们现在都是单元测试，虽然说是 UI 库，但是 E2E 包括 Visual Test 能测试到一些边界情况，算不上是 0 -> 100 的提升，但是 80 -> 89 的提升还是有的吧

codecov · 2020-07-30T15:51:13Z

Codecov Report

Merging #24475 into master will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##            master    #24475   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          389       389           
  Lines         7389      7389           
  Branches      2025      2074   +49     
=========================================
  Hits          7389      7389

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 06b25b4...1b4c255. Read the comment docs.

github-actions · 2020-07-30T15:54:08Z

Size Change: 0 B

Total Size: 791 kB

ℹ️ View Unchanged

Filename	Size	Change
`./dist/antd-with-locales.min.js`	314 kB	0 B
`./dist/antd.compact.min.css`	66.4 kB	0 B
`./dist/antd.dark.min.css`	67.7 kB	0 B
`./dist/antd.min.css`	66.4 kB	0 B
`./dist/antd.min.js`	277 kB	0 B

_{compressed-size-action}

afc163 · 2020-08-13T02:19:04Z

https://percy.io/

shaodahong · 2020-10-23T02:59:00Z

Snapshots: https://www.argos-ci.com/ant-design/ant-design/builds

shaodahong · 2020-10-23T08:49:58Z

@afc163 @zombieJ Github check 还有点问题，其他的应该都是 OK 的，没问题可以先合一版试试

Github check 感觉和 branchName 有关系，我自己测试的仓库是没问题的

测试仓库 shaodahong/jd-happy#36

* test: demo -> ui test * improve comment image width * use argos-ci * use by cicleci * fix circle run * rebase master * try pipeline var * use another branch var * fix commit id * ignore image test file * remove useless report * fix test coverage

ant-design-bot added the Inactive label Jun 27, 2020

afc163 closed this Jul 29, 2020

afc163 reopened this Jul 29, 2020

github-actions bot force-pushed the ui-test-with-demo branch from 401823d to 290d37a Compare July 30, 2020 05:29

shaodahong force-pushed the ui-test-with-demo branch from 2b7197e to d854ec4 Compare October 22, 2020 03:23

shaodahong changed the title ~~[WIP] test: demo -> ui test~~ test: demo -> ui test Oct 22, 2020

pr-triage bot added the PR: unreviewed label Oct 22, 2020

shaodahong mentioned this pull request Oct 23, 2020

How to enable github check? argos-ci/argos#423

Closed

test: demo -> ui test

5deab51

shaodahong added 10 commits October 23, 2020 16:08

improve comment image width

232f80a

use argos-ci

5c2af11

use by cicleci

9bf9689

fix circle run

9f20945

rebase master

e80346c

try pipeline var

36d92b5

use another branch var

4adc600

fix commit id

31ec214

ignore image test file

dd04434

remove useless report

b6f4f0c

shaodahong force-pushed the ui-test-with-demo branch from cdf0d70 to b6f4f0c Compare October 23, 2020 08:10

fix test coverage

1b4c255

shaodahong requested review from afc163 and zombieJ October 23, 2020 08:48

shaodahong requested review from hengkx, kerm1it and yoyo837 October 23, 2020 08:56

afc163 merged commit 6fba4d1 into master Oct 23, 2020

afc163 deleted the ui-test-with-demo branch October 23, 2020 10:50

pr-triage bot added the PR: merged label Oct 23, 2020

shaodahong mentioned this pull request Oct 27, 2020

fix: Fix the width of the step content in the horizontal direction #27406

Merged

19 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

test: demo -> ui test #24475

test: demo -> ui test #24475

shaodahong commented May 26, 2020

ant-design-bot commented May 26, 2020 •

edited

ant-design-bot commented May 26, 2020 •

edited

afc163 commented May 26, 2020

shaodahong commented May 26, 2020

yoyo837 commented May 26, 2020

shaodahong commented May 26, 2020

afc163 commented May 26, 2020 •

edited

shaodahong commented May 26, 2020

yoyo837 commented May 27, 2020

shaodahong commented May 27, 2020

afc163 commented Jul 29, 2020 •

edited

shaodahong commented Jul 29, 2020

07akioni commented Jul 29, 2020

afc163 commented Jul 29, 2020

shaodahong commented Jul 30, 2020

codesandbox-ci bot commented Jul 30, 2020 •

edited

shaodahong commented Jul 30, 2020 •

edited

codecov bot commented Jul 30, 2020 •

edited

github-actions bot commented Jul 30, 2020 •

edited

afc163 commented Aug 13, 2020

shaodahong commented Oct 23, 2020

shaodahong commented Oct 23, 2020 •

edited

test: demo -> ui test #24475

test: demo -> ui test #24475

Conversation

shaodahong commented May 26, 2020

🤔 This is a ...

🔗 Related issue link

💡 Background and solution

📝 Changelog

☑️ Self Check before Merge

ant-design-bot commented May 26, 2020 • edited

ant-design-bot commented May 26, 2020 • edited

afc163 commented May 26, 2020

shaodahong commented May 26, 2020

yoyo837 commented May 26, 2020

shaodahong commented May 26, 2020

afc163 commented May 26, 2020 • edited

shaodahong commented May 26, 2020

yoyo837 commented May 27, 2020

shaodahong commented May 27, 2020

afc163 commented Jul 29, 2020 • edited

shaodahong commented Jul 29, 2020

07akioni commented Jul 29, 2020

afc163 commented Jul 29, 2020

shaodahong commented Jul 30, 2020

codesandbox-ci bot commented Jul 30, 2020 • edited

shaodahong commented Jul 30, 2020 • edited

codecov bot commented Jul 30, 2020 • edited

Codecov Report

github-actions bot commented Jul 30, 2020 • edited

afc163 commented Aug 13, 2020

shaodahong commented Oct 23, 2020

shaodahong commented Oct 23, 2020 • edited

ant-design-bot commented May 26, 2020 •

edited

ant-design-bot commented May 26, 2020 •

edited

afc163 commented May 26, 2020 •

edited

afc163 commented Jul 29, 2020 •

edited

codesandbox-ci bot commented Jul 30, 2020 •

edited

shaodahong commented Jul 30, 2020 •

edited

codecov bot commented Jul 30, 2020 •

edited

github-actions bot commented Jul 30, 2020 •

edited

shaodahong commented Oct 23, 2020 •

edited