Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

jest-dev-server deps difference between repository and npm (wait-on package) #358

Closed
dartess opened this issue Jun 8, 2020 · 1 comment · Fixed by #392
Closed

jest-dev-server deps difference between repository and npm (wait-on package) #358

dartess opened this issue Jun 8, 2020 · 1 comment · Fixed by #392

Comments

@dartess
Copy link

dartess commented Jun 8, 2020 •
edited

Hi!

In repo jest-dev-server has in deps "wait-on": "^4.0.0" (https://github.com/smooth-code/jest-puppeteer/blob/master/packages/jest-dev-server/package.json)

But when I install jest-dev-server from npm I get in deps "wait-on": "^3.3.0"

How could this happen? And will it be fixed?

UPD: "wait-on": "^4.0.0" still used request package as deps. request is deprecated now. It would be cool to upgrade wait-on to 5 version.
@dartess dartess mentioned this issue Aug 27, 2020
Closed
@dartess dartess changed the title jest-dev-server deps difference between repository and npm jest-dev-server deps difference between repository and npm (wait-on package) Sep 2, 2020
@dartess
Copy link
Author

dartess commented Sep 2, 2020 •
edited

upd: https://github.com/jeffbski/wait-on/releases/tag/v5.0.0

wait-on 5 has breaking changes, jest probably should update jest major version too

@UziTech UziTech mentioned this issue Apr 8, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update all dependencies UziTech/jest-puppeteer
1 participant
@dartess