Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wait-on 4.4.0 #340

Closed
thernstig opened this issue Apr 6, 2020 · 3 comments · Fixed by #392
Closed

wait-on 4.4.0 #340

thernstig opened this issue Apr 6, 2020 · 3 comments · Fixed by #392

Comments

@thernstig
Copy link

According to https://github.com/smooth-code/jest-puppeteer/blob/master/packages/jest-dev-server/package.json version 4.4.0 contains wait-on ^4.0.0. How is it that when I install jest-dev-server my package.lock looks like this?

    "jest-dev-server": {
      "version": "4.4.0",
      "resolved": "https://arm.sero.gic.ericsson.se/artifactory/api/npm/npm-remote/jest-dev-server/-/jest-dev-server-4.4.0.tgz",
      "integrity": "sha1-VXET+q4od0UhYmlqqUweREkasBE=",
      "dev": true,
      "requires": {
        "chalk": "^3.0.0",
        "cwd": "^0.10.0",
        "find-process": "^1.4.3",
        "prompts": "^2.3.0",
        "spawnd": "^4.4.0",
        "tree-kill": "^1.2.2",
        "wait-on": "^3.3.0"
      }
    },

Notice ^3.3.0 and not ^4.0.0?

@mxschmitt
Copy link

Seems like a new version needs to be released, because currently its still the old version.

A fix was already merged, see PR #316.

@thernstig
Copy link
Author

@gregberge Sorry for pinging you, but any chance you would want to make a release? :)

@dartess
Copy link

dartess commented Aug 27, 2020

it would be better to get version 5 now #358

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants