spawnd package should have exit as a dependency, not a devDependency

[9at8]

🐛 Bug Report

The spawnd package should list exit as a dependency as it uses it during runtime, not as a devDependency. Or better, we can just remove exit as a dependency because the issue that it tries to fix has been fixed in nodejs for a while now.

To Reproduce

See the link to repo section below.

Expected behavior

Tests run without any errors.

Link to repl or repo (highly encouraged)

1. Run yarn in this repo/path
2. Run yarn run test
3. We get an error like this:

Error: Jest: Got error running globalSetup - D:\src\github.com\microsoft\vs-servicehub\src\servicebroker-npm\.yarn\cache\jest-environment-puppeteer-npm-8.0.3-43c7b636f5-1fde0abdc7.zip\node_modules\jest-environment-puppeteer\setup.js, reason: spawnd tried to access exit, but it isn't declared in its dependencies; this makes the require call ambiguous and unsound.

Required package: exit
Required by: spawnd@npm:8.0.0 (via D:\src\github.com\microsoft\vs-servicehub\src\servicebroker-npm\.yarn\cache\spawnd-npm-8.0.0-9b09b2e92d-04f2e61218.zip\node_modules\spawnd\dist\)

Require stack:
- D:\src\github.com\microsoft\vs-servicehub\src\servicebroker-npm\.yarn\cache\spawnd-npm-8.0.0-9b09b2e92d-04f2e61218.zip\node_modules\spawnd\dist\index.js
- D:\src\github.com\microsoft\vs-servicehub\src\servicebroker-npm\.yarn\cache\jest-dev-server-npm-8.0.3-9e04316429-2bb4725f51.zip\node_modules\jest-dev-server\dist\index.js
- D:\src\github.com\microsoft\vs-servicehub\src\servicebroker-npm\.yarn\cache\jest-environment-puppeteer-npm-8.0.3-43c7b636f5-1fde0abdc7.zip\node_modules\jest-environment-puppeteer\dist\global-init.js
- D:\src\github.com\microsoft\vs-servicehub\src\servicebroker-npm\.yarn\cache\jest-environment-puppeteer-npm-8.0.3-43c7b636f5-1fde0abdc7.zip\node_modules\jest-environment-puppeteer\setup.js
- D:\src\github.com\microsoft\vs-servicehub\src\servicebroker-npm\.yarn\cache\jest-util-npm-29.5.0-cf917d20f1-fd9212950d.zip\node_modules\jest-util\build\requireOrImportModule.js
- D:\src\github.com\microsoft\vs-servicehub\src\servicebroker-npm\.yarn\cache\jest-util-npm-29.5.0-cf917d20f1-fd9212950d.zip\node_modules\jest-util\build\index.js
- D:\src\github.com\microsoft\vs-servicehub\src\servicebroker-npm\.yarn\__virtual__\jest-config-virtual-0845b62117\0\cache\jest-config-npm-29.5.0-15ac67fe8b-c37c4dab96.zip\node_modules\jest-config\build\getCacheDirectory.js
- D:\src\github.com\microsoft\vs-servicehub\src\servicebroker-npm\.yarn\__virtual__\jest-config-virtual-0845b62117\0\cache\jest-config-npm-29.5.0-15ac67fe8b-c37c4dab96.zip\node_modules\jest-config\build\Defaults.js
- D:\src\github.com\microsoft\vs-servicehub\src\servicebroker-npm\.yarn\__virtual__\jest-config-virtual-0845b62117\0\cache\jest-config-npm-29.5.0-15ac67fe8b-c37c4dab96.zip\node_modules\jest-config\build\normalize.js
- D:\src\github.com\microsoft\vs-servicehub\src\servicebroker-npm\.yarn\__virtual__\jest-config-virtual-0845b62117\0\cache\jest-config-npm-29.5.0-15ac67fe8b-c37c4dab96.zip\node_modules\jest-config\build\index.js
- D:\src\github.com\microsoft\vs-servicehub\src\servicebroker-npm\.yarn\__virtual__\jest-cli-virtual-bb4503abae\0\cache\jest-cli-npm-29.5.0-3746aee7e9-39897bbbc0.zip\node_modules\jest-cli\build\init\index.js
- D:\src\github.com\microsoft\vs-servicehub\src\servicebroker-npm\.yarn\__virtual__\jest-cli-virtual-bb4503abae\0\cache\jest-cli-npm-29.5.0-3746aee7e9-39897bbbc0.zip\node_modules\jest-cli\build\run.js
- D:\src\github.com\microsoft\vs-servicehub\src\servicebroker-npm\.yarn\__virtual__\jest-cli-virtual-bb4503abae\0\cache\jest-cli-npm-29.5.0-3746aee7e9-39897bbbc0.zip\node_modules\jest-cli\build\index.js
- D:\src\github.com\microsoft\vs-servicehub\src\servicebroker-npm\.yarn\__virtual__\jest-cli-virtual-bb4503abae\0\cache\jest-cli-npm-29.5.0-3746aee7e9-39897bbbc0.zip\node_modules\jest-cli\bin\jest.js
- D:\src\github.com\microsoft\vs-servicehub\src\servicebroker-npm\.yarn\__virtual__\jest-virtual-38d8fd45f4\0\cache\jest-npm-29.5.0-77b78b2adf-a8ff2eb0f4.zip\node_modules\jest\bin\jest.js
    at Function.require$$0.Module._resolveFilename (D:\src\github.com\microsoft\vs-servicehub\src\servicebroker-npm\.pnp.cjs:21484:13)
    at Function.Module._resolveFilename.sharedData.moduleResolveFilenameHook.installedValue [as _resolveFilename] (D:\src\github.com\microsoft\vs-servicehub\src\servicebroker-npm\.yarn\cache\@cspotcode-source-map-support-npm-0.8.1-964f2de99d-5718f26708.zip\node_modules\@cspotcode\source-map-support\source-map-support.js:811:30)
    at Function.require$$0.Module._load (D:\src\github.com\microsoft\vs-servicehub\src\servicebroker-npm\.pnp.cjs:21334:42)
    at Module.require (node:internal/modules/cjs/loader:1061:19)
    at require (node:internal/modules/cjs/helpers:103:18)
    at Object.<anonymous> (D:\src\github.com\microsoft\vs-servicehub\src\servicebroker-npm\.yarn\cache\spawnd-npm-8.0.0-9b09b2e92d-04f2e61218.zip\node_modules\spawnd\dist\index.js:6:12)
    at Module._compile (node:internal/modules/cjs/loader:1159:14)
    at Module._extensions..js (node:internal/modules/cjs/loader:1213:10)
    at require$$0.Module._extensions..js (D:\src\github.com\microsoft\vs-servicehub\src\servicebroker-npm\.pnp.cjs:21528:33)
    at require.extensions.<computed> (D:\src\github.com\microsoft\vs-servicehub\src\servicebroker-npm\.yarn\__virtual__\ts-node-virtual-3ff0b514d1\0\cache\ts-node-npm-10.9.1-6c268be7f4-090adff130.zip\node_modules\ts-node\src\index.ts:1608:43)

Run npx envinfo --system --binaries --npmPackages expect-puppeteer,jest-dev-server,jest-environment-puppeteer,jest-puppeteer,spawnd --markdown --clipboard

I'm using yarn pnp so the npm packages aren't showing up, so I'll paste in the versions manually from yarn.lock

Paste the results here:

## System:
 - OS: Windows 10 10.0.22621
 - CPU: (20) x64 Intel(R) Core(TM) i9-10900 CPU @ 2.80GHz
 - Memory: 35.56 GB / 63.71 GB
## Binaries:
 - Node: 18.12.0 - C:\Program Files\nodejs\node.EXE
 - Yarn: 3.3.1 - C:\Program Files\nodejs\yarn.CMD
 - npm: 8.19.2 - C:\Program Files\nodejs\npm.CMD

"expect-puppeteer@npm:^8.0.3":
  version: 8.0.3

"jest-dev-server@npm:^8.0.3":
  version: 8.0.3

"jest-environment-puppeteer@npm:^8.0.3":
  version: 8.0.3

"jest-puppeteer@npm:^8.0.3":
  version: 8.0.3

"spawnd@npm:^8.0.0":
  version: 8.0.0