Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve imports #297

Open
PJ-Finlay opened this issue Oct 14, 2022 · 1 comment
Open

Improve imports #297

PJ-Finlay opened this issue Oct 14, 2022 · 1 comment
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@PJ-Finlay
Copy link
Collaborator

The Python imports are currently a mess I'd like to improve at some point. I can accept pull requests or suggestions for beat practices. Ideally we would use something that can be enforced with CI, I currently use the "black" tool to format the code but it doesn't organize the order of imports.
@PJ-Finlay PJ-Finlay added enhancement New feature or request help wanted Extra attention is needed good first issue Good for newcomers labels Oct 14, 2022
@PJ-Finlay
Copy link
Collaborator Author

PEP 8 import order

Imports should be grouped in the following order:

  1. Standard library imports.
  2. Related third party imports.
  3. Local application/library specific imports.

argosopentech pushed a commit that referenced this issue Oct 16, 2022
@PJ-Finlay
Improve argostranslate.translate imports
b31fe31 
#297
AABur added a commit to AABur/argos-translate that referenced this issue Nov 27, 2022
@AABur
Fix Improve imports argosopentech#297
e4013f7
PJ-Finlay pushed a commit that referenced this issue Nov 29, 2022
@AABur @PJ-Finlay
Fix Improve imports #297
978cbc8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@PJ-Finlay