store cached translations #339
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Video demo https://youtu.be/UoMVIKUTWJ0 |
|
Wow! Thanks for submitting this I had heard reports that there might be a memory leak in LibreTranslate but had no idea where. https://community.libretranslate.com/t/libretranslate-under-load/482 https://community.libretranslate.com/t/memory-leak-in-argos-translate/638 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request fixing a bug in this issue #337
Created a global storage array of
CachedTranslationobjects by unique keys.I tried to make as few changes as possible and as safe as possible. Perhaps this approach is not the best in terms of code style and in the future it may be refactored, but for now the main thing is that it completely eliminates a huge part of the memory leak due to the fact that objects are not created each time new ones, but once created from memory are taken.