Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Limit max number of scores associated with max boxes. #226

Merged
merged 9 commits into from
May 24, 2021
Merged

Limit max number of scores associated with max boxes. #226

merged 9 commits into from
May 24, 2021

Conversation

benjaminrwilson
Copy link
Contributor

@benjaminrwilson benjaminrwilson commented May 24, 2021 •
edited
Loading

Fixes two issues:

  1. Corrects typing of args in rank.
  2. The scores array was incorrect when the number of detections exceeded the maximum allowed.
  3. Scores are sorted now in the case that someone submits unordered detections.

tagarwal-argoai
tagarwal-argoai approved these changes May 24, 2021
View reviewed changes
Copy link
Contributor

@tagarwal-argoai tagarwal-argoai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

argoverse/evaluation/detection/utils.py Show resolved Hide resolved
argoverse/evaluation/detection/utils.py Outdated Show resolved Hide resolved
johnwlambert
johnwlambert approved these changes May 24, 2021
View reviewed changes
Copy link
Contributor

@johnwlambert johnwlambert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jagjeet-singh jagjeet-singh merged commit 778da7e into argoverse:master May 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jagjeet-singh jagjeet-singh jagjeet-singh left review comments

@johnwlambert johnwlambert johnwlambert approved these changes

@tagarwal-argoai tagarwal-argoai tagarwal-argoai approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@benjaminrwilson @jagjeet-singh @johnwlambert @tagarwal-argoai