Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make angle a named parameter for matplotlib Rectangle constructor #235

Merged
merged 1 commit into from
Dec 13, 2023

Conversation

viktortnk
Copy link
Contributor

PR Summary

make angle a named parameter for matplotlib Rectangle constructor

https://matplotlib.org/stable/api/_as_gen/matplotlib.patches.Rectangle.html

According to the latest documentation matplotlib's Rectangle has only 3 positional arguments (not 4 as earlier).

As the name of parameters matches, the change should be compatible with earlier version of the library

Testing

In order to ensure this PR works as intended, it is:

  • unit tested.
  • other or not applicable (additional detail/rationale required)

Compliance with Standards

As the author, I certify that this PR conforms to the following standards:

  • Code changes conform to PEP8 and docstrings conform to the Google Python style guide.
  • A well-written summary explains what was done and why it was done.
  • The PR is adequately tested and the testing details and links to external results are included.

@benjaminrwilson
Copy link
Collaborator

Hi @viktortnk , thank you for the PR! Would you mind pulling in the latest changes from main so we can resolve the CI?

@viktortnk
Copy link
Contributor Author

Hi @benjaminrwilson
Sure, rebased.
I see all checks are green now

@benjaminrwilson benjaminrwilson merged commit 574a5e1 into argoverse:main Dec 13, 2023
18 checks passed
@benjaminrwilson
Copy link
Collaborator

Great, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants