fix compilation with mingw #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`_Sleep' referenced in section `.text' of libargp.a(argp-parse.c.o): defined in discarded section `.text' of /.../lib/libkernel32.a(dvclds01385.o) https://stackoverflow.com/questions/31085538/function-referenced-in-section-text-of-defined-in-discarded-section-te
|
Can't reproduce the bug, I'm using MSYS2's MINGW64 environment on a Windows 10 machine. Compiling and passing Will merge later anyway. |
|
I'm cross compiling from Linux for mingw i686 |
|
Makes sense, 32-bit Windows is the one that has many calling conventions and stackoverflow says this is due to functions with different calling conventions having different symbols on Windows. I've cross compiled for i686 mingw and confirmed that the bug is present in master as well that this PR fixes it by running the binary on a real Windows system. |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
_Sleep' referenced in section.text' of libargp.a(argp-parse.c.o): defined in discarded section `.text' of /.../lib/libkernel32.a(dvclds01385.o)https://stackoverflow.com/questions/31085538/function-referenced-in-section-text-of-defined-in-discarded-section-te