Skip to content

Commit

Permalink
fix: Prevent forcing users upgrading CMake to 3.12
Browse files Browse the repository at this point in the history
We didn't notice that using add_compile_definitions will force
developers upgrading their CMake to 3.12. Go back using the old
add_definitions() so we can keep using CMake 3.0.

resolves: #48
  • Loading branch information
tomghuang committed May 19, 2020
1 parent d1f6cde commit 90dce83
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 4 deletions.
2 changes: 1 addition & 1 deletion examples/CMakeLists.txt
Expand Up @@ -29,7 +29,7 @@
################################################################################

if(ARGTABLE3_ENABLE_ARG_REX_DEBUG)
add_compile_definitions(ARG_REX_DEBUG)
add_definitions(-DARG_REX_DEBUG)
endif()

file(GLOB EXAMPLES_SOURCES RELATIVE ${PROJECT_SOURCE_DIR}/examples *.c)
Expand Down
4 changes: 2 additions & 2 deletions src/CMakeLists.txt
Expand Up @@ -44,10 +44,10 @@ else(CMAKE_C_COMPILER_ID MATCHES "GNU|Clang")
endif()

if(ARGTABLE3_ENABLE_ARG_REX_DEBUG)
add_compile_definitions(ARG_REX_DEBUG)
add_definitions(-DARG_REX_DEBUG)
endif()

add_compile_definitions(_XOPEN_SOURCE=700)
add_definitions(-D_XOPEN_SOURCE=700)

if(WIN32)
set(COMPANY_NAME "The Argtable3 Project")
Expand Down
2 changes: 1 addition & 1 deletion tests/CMakeLists.txt
Expand Up @@ -29,7 +29,7 @@
################################################################################

if(ARGTABLE3_ENABLE_ARG_REX_DEBUG)
add_compile_definitions(ARG_REX_DEBUG)
add_definitions(-DARG_REX_DEBUG)
endif()

set(TEST_PUBLIC_SRC_FILES
Expand Down

0 comments on commit 90dce83

Please sign in to comment.