stack corruption for long cmdline args #78
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chipweinberger
commented
Oct 20, 2022
| dest++; | ||
|
|
||
| /* concat src string to dest string */ | ||
| while (dest < end && *src != 0) | ||
| while (dest < end-1 && *src != 0) |
There was a problem hiding this comment.
end is past the end of the buffer. end = dest + buffer_size.
i.e. if end is 0x05, the last time would should enter the loop (& increment dest) is when dest is 0x03.
last iteration: 0x03 < 0x04 -> dest will become 0x04
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see: espressif/esp-idf#10016