chore: some minor improvements #1210
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arthurpaulino
force-pushed
the
ap/minor-improvements
branch
from
c7eb5c9
to
1365c75
Compare
* avoid some copies where we already require ownership * use `car_cdr_simple` where we're not interested in deconstructing strings * use `fetch_cons` where we explicitly require the pointer's tag to be `Cons`
arthurpaulino
force-pushed
the
ap/minor-improvements
branch
from
1365c75
to
cdc147e
Compare
gabriel-barrett
approved these changes
Mar 11, 2024
samuelburnham
approved these changes
Mar 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
car_cdr_simplewhere we're not interested in deconstructing stringsfetch_conswhere we explicitly require the pointer's tag to beCons