Overridden mapgen settings ignored in settings.lua #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use `minetest.get_mapgen_setting()` instead of `minetest.settings:get()` when getting: mapgen_limit, chunksize, and water_level.
The issue is that `minetest.settings:get()` only gets values from the minetest.conf file, but these 3 settings are mapgen settings and can be overriden in the per-world map_meta.txt file. The `minetest.get_mapgen_setting()` function checks both and returns the same value that's used by the mapgen. For example:
minetest.conf has:
* mapgen_limit = 31000
* water_level = 1
map_meta.txt (for one particular world) has:
* mapgen_limit = 5000
* water_level = 70
`minetest.settings:get("mapgen_limit")` returns: 31000
`minetest.get_mapgen_setting("mapgen_limit")` returns: 5000 (and is the actual value used by mapgen)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use
minetest.get_mapgen_setting()instead ofminetest.settings:get()when getting:mapgen_limit,chunksize, andwater_level.The issue is that
minetest.settings:get()only gets values from the minetest.conf file, but these 3 settings are mapgen settings and can be overridden in the per-world map_meta.txt file. Theminetest.get_mapgen_setting()function checks both and returns the same value that's used by the mapgen. For example:minetest.conf has:
map_meta.txt (for one particular world) has:
minetest.settings:get("mapgen_limit")returns: 31000minetest.get_mapgen_setting("mapgen_limit")returns: 5000 (and is the actual value used by mapgen)Take care,
Solomon...
https://SqlQuantumLift.com/
https://SqlQuantumLeap.com/
https://SQLsharp.com/