Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Settings aren't touch-friendly #14

Closed
lukaszciastko-spica opened this issue Mar 21, 2021 · 1 comment · Fixed by #15
Closed

Settings aren't touch-friendly #14

lukaszciastko-spica opened this issue Mar 21, 2021 · 1 comment · Fixed by #15

Comments

@lukaszciastko-spica
Copy link

I really like your Settings example and the article that goes with it. Is there any chance you could update it and also try and make it touch-friendly?

I tested it on my iPhone, and the handles are very difficult to tap - one has to be very precise when trying to grab them as the touch area is the size of a handle. The same goes for checkboxes - you can tap on the text next to them but not within the area around them. Also, when you tap (either on the handle or the checkbox), the hover shadow doesn't go away.

Thank you!

@argyleink
Copy link
Owner

thanks for the report! what do you think of the PR which increases the size of the thumb and checkbox when the user is ~on a touch device (coarse hover or no hover)?

argyleink added a commit that referenced this issue Aug 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants