Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

scrollthumb updates #243

Merged
merged 1 commit into from Jul 2, 2022
Merged

scrollthumb updates #243

merged 1 commit into from Jul 2, 2022

Conversation

hchiam
Copy link
Contributor

@hchiam hchiam commented Jul 2, 2022

Fixes #229:

  • renamed --scrollbar-color to --scrollthumb-color
  • set grays that pass WCAG AA contrast ratios against surfaces in dark and light modes

/docsite on http://localhost:3000/ in Dark Mode:

dark

/docsite on http://localhost:3000/ in Light Mode:

light

…ass WCAG AA contrast ratios with surfaces in dark and light modes
Copy link
Contributor Author

@hchiam hchiam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ready for review.

@argyleink argyleink merged commit 6936837 into argyleink:main Jul 2, 2022
kelvindecosta pushed a commit to kelvindecosta/open-props that referenced this pull request Nov 16, 2022
…ass WCAG AA contrast ratios with surfaces in dark and light modes (argyleink#243)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rename --scrollbar-color to --scrollthumb-color
2 participants