Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #278 and extend with --firefoxMacONLY, --chromiumONLY, --webkitONLY #280

Merged
merged 1 commit into from Sep 21, 2022

Conversation

WebMechanic
Copy link
Contributor

Test page and explainer https://codepen.io/WebMechanic/pen/poVexYp?editors=1100

Sources:

container-type:none is a non-standard value to test against. It must not be changed to inherit which is usually sufficient and safe to check property support.

Copy link
Owner

@argyleink argyleink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so far my tests have gone good and the updates seem fair. it is odd seeing container-type: none in there, but the reasoning seems good.

going to test more at work. thanks for this!

@argyleink
Copy link
Owner

where did you learn that container-type:none matched?
i'm on the fence about the chromium one, you?

@WebMechanic
Copy link
Contributor Author

where did you learn that container-type:none matched?

using Lea Verou's https://css3test.com/ ("Experimental" filter selected) in Containment Level 3 / Properties.
It was "green" in Chromium but not in Chrome.

This is Chrome 105 (and WebKit "16")

image

i'm on the fence about the chromium one, you?

It could be useful to tweak font stuff but that's all I can think of now :)

That's likely the test that might break[^1] sooner or later[^2]. I wouldn't mind, if you want to skip it. It was more of a challenge to find sth at all and some sort of a "first match pick" from Lea's site. There could be others 🤷‍♂️ .

To be frank: we virtually have no Chromium or Linux visitors in our analytics so we don't really test in that browser. If stuff works in Chrome it's fair to presume it works in Chromium too. Both are very much on par with their CSS for "real world work".

I wouldn't add it back in for our copy. It's now "documented" and if somebody needs different style for Chrome and Chromium, here's how they learn how :D or scan css3test.com for sth else.

Your descision after all.

[^1] I just saw that Firefox' experimental implementation parses all properties here = it's all green.
[^2] 'none' appears to be from the 20211221 draft. It has since been removed. So should Chromium update their implementation it might be gone, too.

@argyleink argyleink marked this pull request as ready for review September 21, 2022 18:03
@argyleink argyleink merged commit 537f061 into argyleink:main Sep 21, 2022
kelvindecosta pushed a commit to kelvindecosta/open-props that referenced this pull request Nov 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants