Add missing exports for masks and media js files #326
Conversation
|
|
There was a problem hiding this comment.
thanks for catching and adding those 🙂
this looks good to me except the duplicate media entry.
Side thought:
maybe i should make a separate issue to normalize the naming convention so all the js modules use the esm/ prefix 🤔
Side Q:
what env are you in that you can't reach into the package and grab any file you want? which env is forcing you only to importing exported items? import "open-props/docsite/syntax-highlight.css"; should just work if someone wants it to?
package.json
Outdated
| @@ -39,6 +39,9 @@ | |||
| "./src/sizes": "./src/props.sizes.js", | |||
| "./src/svg": "./src/props.svg.js", | |||
| "./src/zindex": "./src/props.zindex.js", | |||
| "./src/media": "./src/props.media.js", | |||
There was a problem hiding this comment.
this was already exposed as "./esm/media": "./src/props.media.js", 👍🏻
There was a problem hiding this comment.
ooh, i missed that. undone! 👍
if you would like everything to be under esm/, i can update the other two as well.
the documentation mentions src/ fwiw
There was a problem hiding this comment.
i'll fix in #327, thanks!
that is technically a breaking change, jsyk (after you mentioned esm/media, i added it in my script. now if i upgrade to 1.5.2, it will break my script)
There was a problem hiding this comment.
yeah, it is technically one! but i also silently released it, never documented it and have discord if anyone else finds the feature and change.
makes sense to me! but the old export paths would need to be kept around to avoid breaking changes.
it's just a plain node esm environment (i'm building a wrapper over open-props using an import MaskEdges from 'open-props/src/props.masks.edges.js'; |
|
which bundler is doing that npm lookup? also, adding |
added `media.js`, `masks.edges.js` and `masks.corner-cuts.js` to exports because they were previously missing and impossible to import.
there is no bundler. it is just a plain node script running in ESM mode. the command i run is if there was a bundler though, i do know vite/astro use plain node ESM for SSR
done! |
|
released in |
added
media.js,masks.edges.jsandmasks.corner-cuts.jsto exports because they were previously missing and impossible to import.unsure if this is the right convention (i couldn't find any previous examples with multiple dots in the file name)
also, i didn't include it in this pr but it might help to add a catch-all to the export map. this will make sure everything is exposed (unless some things are purposely hidden).